search

Ghost-chu / QuickShop-Reremake

QuickShop is a shop plugin that allows players to easily sell/buy any items from a chest without any commands. In fact, none of the commands that QuickShop provides are ever needed by a player.
GNU General Public License v3.0
103 stars 147 forks source link

[BUG] Item preview shows actual Item name instead of custom name #1538

Closed Andre601 closed 2 years ago

Andre601 commented 2 years ago

Description

When left-clicking a shop sign to buy an item will the Item name listed (The one you can click on to see a preview) display the actual item name and not any custom one it may have, if the item was renamed.

Steps to reproduce

  1. Create a shop selling a renamed (and custom textured) item.
  2. Left-click the sign to enter buy mode
  3. See how the base item name is used and not the custom one (3rd line in UI)

Expected Behaviour

QuickShop should display the actual name displayed by the item (The one you set during renaming)

Screenshots

See the "Gegenstand" line image

/qs paste URL

https://paste.helpch.at/afovuxecej

Additional Context

The hover text applied to the item name is actually displaying the display name of the item itself.

Ghost-chu commented 2 years ago

confirmed

Ghost-chu commented 2 years ago

try this build: https://ci.codemc.io/job/Ghost-chu/job/QuickShop-Reremake-SNAPSHOT/1907/artifact/target/QuickShop.jar

try to fix it on the phone, not tested yet.

reopen this issue if still not working

Andre601 commented 2 years ago

Doesn't fix it. Also, I can't reopen issues that are closed by others... even my own.

Ghost-chu commented 2 years ago

will look it after I back to my dormitory

Ghost-chu commented 2 years ago

please try this build: https://ci.codemc.io/job/Ghost-chu/job/QuickShop-Reremake-SNAPSHOT/1908/artifact/target/QuickShop.jar

Andre601 commented 2 years ago

This fixed the issue, thanks.