search

Ghost-chu / QuickShop-Reremake

QuickShop is a shop plugin that allows players to easily sell/buy any items from a chest without any commands. In fact, none of the commands that QuickShop provides are ever needed by a player.
GNU General Public License v3.0
103 stars 147 forks source link

[BUG] #1553

Closed ItsSynchro closed 2 years ago

ItsSynchro commented 2 years ago

Description

Modified messages.yml's have a "Missing Language" line where the name of the item is supposed to be for "Out of Stock" shops.

Steps to reproduce

  1. Use https://paste.gg/p/anonymous/c07f8978e77d49a7b936ce8026547b2f
  2. Left click on a shop or buy out a shop till its "Out of Stock"

Expected Behaviour

Show the actual item that has Ran Out of Stock instead of showing "Missing Language"

Screenshots

2021-11-02_17 24 40

/qs paste URL

https://paste.helpch.at/ituqofeqez

Additional Context

No response

Ghost-chu commented 2 years ago

Make sure your override file is valid JSON format.

ItsSynchro commented 2 years ago

Make sure your override file is valid JSON format.

In the "Steps to Reproduce" I provided my messages.yml. I've gone ahead and pasted it inside jsonlint.com and it says its a "valid JSON" Screenshot 2021-11-02 192558

Ghost-chu commented 2 years ago

Make sure your override file is valid JSON format.

In the "Steps to Reproduce" I provided my messages.yml. I've gone ahead and pasted it inside jsonlint.com and it says its a "valid JSON" Screenshot 2021-11-02 192558

override file can only override part of texts, try only add the texts that modified.

I will check this issue later.

Ghost-chu commented 2 years ago

also, if you trying override the section, you must make sure all keys in section has been correctly override. Or they will missing.

ItsSynchro commented 2 years ago

also, if you trying override the section, you must make sure all keys in section has been correctly override. Or they will missing.

Sorry but I'm a little bit confused... Previously, my messages.json file worked perfectly fine whilst in the default directory when previously to updating to the big update. However after the major update it ceased working. I would really love some sort of example as to what you mean as I'd like to go back to using my modified messages.json

Ghost-chu commented 2 years ago

also, if you trying override the section, you must make sure all keys in section has been correctly override. Or they will missing.

Sorry but I'm a little bit confused... Previously, my messages.json file worked perfectly fine whilst in the default directory when previously to updating to the big update. However after the major update it ceased working. I would really love some sort of example as to what you mean as I'd like to go back to using my modified messages.json

we nolonger use messages.json in this big update, so plugin won't read it of course.

Ghost-chu commented 2 years ago

should fixed in 5.0.0.7