search

Ghost-chu / QuickShop-Reremake

QuickShop is a shop plugin that allows players to easily sell/buy any items from a chest without any commands. In fact, none of the commands that QuickShop provides are ever needed by a player.
GNU General Public License v3.0
103 stars 147 forks source link

[BUG] QuickShop prints nonsense messages and doesn't load shops(?) #1561

Closed Andre601 closed 2 years ago

Andre601 commented 2 years ago

Description

When QuickShop is enabling does it print the following warnings:

[14:53:27 ERROR]: [QuickShop] The selected economy handler not installed
[14:53:27 ERROR]: [QuickShop] Please check the configuration.
[14:53:27 ERROR]: [QuickShop] No Economy plugin detected! Please make sure that you have a
[14:53:27 ERROR]: [QuickShop] compatible economy plugin installed to get Vault working.

This warning is printed twice. Once the shop has enabled fully and once it loads the shops. In addition, does QuickShop say that there are 0 shops loaded despite having 4 shops in the main world.

Steps to reproduce

  1. Download 5.0.0.7 of QuickShop
  2. Stop Server
  3. Upload new jar
  4. Start Server
  5. Observe issue

Expected Behaviour

QuickShop should load like normal without the warnings

Screenshots

N/A

/qs paste URL

https://paste.helpch.at/toyotemudi

Additional Context

Ghost-chu commented 2 years ago

Fixed in 5.0.0.8

Andre601 commented 2 years ago

Can cofirm it's fixed, but QS still prints that 0 shops have been loaded which isn't true. In addition does it print the Using economy system: EssentialsX Economy line twice too.

Example log output

[17:24:38 INFO]: [QuickShop] Log actions is enabled, actions will log in the qs.log file!
[17:24:38 INFO]: [QuickShop] QuickShop Loaded! 1019 ms.
[17:24:38 INFO]: [QuickShop] Using economy system: EssentialsX Economy
[17:24:39 INFO]: [PowerPlugins] Performing plugin checks...
[17:24:39 INFO]: [PowerPlugins] QuickShop has been updated. Adding to Queue...
[17:24:39 INFO]: [PowerPlugins] Plugin checks finished! Sending webhooks...
[17:24:39 INFO]: [PowerPlugins] Sending Notification about 1 plugins...
[17:24:39 INFO]: [PowerPlugins] Finished sending of webhooks. Cleaning up WebhookManager...
[17:24:39 INFO]: [PlaceholderAPI] Placeholder expansion registration initializing...
[17:24:39 INFO]: Running delayed init tasks
[17:24:39 INFO]: [DecentHolograms] Loading holograms...
[17:24:39 INFO]: [DecentHolograms] Loaded 8 holograms!
[17:24:39 INFO]: [Essentials] Essentials found a compatible payment resolution method: Vault Compatibility Layer (v1.7.3-b131)!
[17:24:39 INFO]: [Essentials] Fetching version information...
[17:24:39 INFO]: [ItemsAdder] [Pack] Checking for online default resourcepack updates...
[17:24:39 INFO]: [Vault] Checking for Updates ... 
[17:24:39 INFO]: [QuickShop] Registering bStats metrics...
[17:24:39 INFO]: [Vault] No new version available
[17:24:39 INFO]: [ItemsAdder] [Pack] No need to download default resourcepack. Cached file is up to date
[17:24:39 INFO]: [ItemsAdder] You can ignore this message: Can't connect to SpigotMC.org, probably internet connection is blocked.
[17:24:39 INFO]: [ItemsAdder] ( Server returned HTTP response code: 503 for URL: https://www.spigotmc.org/members/56829/ ) - 56829
[17:24:39 INFO]: [Citizens] Loaded 3 NPCs.
[17:24:39 INFO]: [QuickShop] Loading the shops in worlds...
[17:24:39 INFO]: [QuickShop] Successfully loaded 0 shops!
[17:24:39 INFO]: [QuickShop] Using economy system: EssentialsX Economy
Ghost-chu commented 2 years ago
  1. QuickShop will try load economy system while starting up, then load again after server completely started up. So there have twice lines.
  2. ShopLoader seems contains some bugs, But it should won't effect actually shops loading, we will check that.
Ghost-chu commented 2 years ago

shop loader fixed