search

Ghost-chu / QuickShop-Reremake

QuickShop is a shop plugin that allows players to easily sell/buy any items from a chest without any commands. In fact, none of the commands that QuickShop provides are ever needed by a player.
GNU General Public License v3.0
103 stars 148 forks source link

[BUG] Quickshop changes disable-move-event: in the paper.yml file even if hopper protection is disabled #802

Closed Kenaestic closed 3 years ago

Kenaestic commented 3 years ago

Describe the bug When using Paperspigot, the plugin changes the disable-move-event setting under hoppers to true even if you disabled hopper protection in the quickshop config. It doesn't matter if I try to disable the hopper protection, do a restart and then change the quickshop protection and vice versa. I tried disabling and deleting the cache but that didn't help either. I also regenerated the config file.

To Reproduce Steps to reproduce the behavior:

  1. Change hopper protection to false in the quickshop config.
  2. Change disable-move-event to true in paper.yml
  3. Restart the server
  4. See warning

Expected behavior It should do nothing with the paper.yml file if the protection is off. I'd even go as far and say it shouldn't change the paper.yml file at all. A warning at server start-up should be enough.

Screenshots image image

Paste link: Execute command /qs paste, you will get a link contains your server information, paste it under this text. You must create a paste, except plugin completely won't work. If you create failed, you should find a paste file under the plugin/QuickShop folder.

Additional context Paper version: 1.16.4, 448. Quickshop version: 4.0.6.3 Java version: jdk-11.0.10+9 Windows

It also shows this in the console while starting up: [02:41:40 WARN]: SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". [02:41:40 WARN]: SLF4J: Defaulting to no-operation (NOP) logger implementation [02:41:40 WARN]: SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

[02:41:40 INFO]: [QuickShop] Enabling QuickShop v4.0.6.3
[02:41:40 INFO]: [QuickShop] Quickshop Reremake
[02:41:40 INFO]: [QuickShop] Running QuickShop-Reremake on NMS version v1_16_R3 For Minecraft version 1.16.5
[02:41:40 INFO]: [QuickShop] Reading the configuration...
[02:41:40 INFO]: [QuickShop] Developers: PotatoCraft Studio, Netherfoam, Timtower, KaiNoMood, Ghost_chu, Mgazul, TiaraRinne, sandtechnology
[02:41:40 INFO]: [QuickShop] Original author: Netherfoam, Timtower, KaiNoMood
[02:41:40 INFO]: [QuickShop] Let's start loading the plugin
[02:41:40 INFO]: [QuickShop] Chat processor selected: BUNGEECHAT
[02:41:40 WARN]: SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
[02:41:40 WARN]: SLF4J: Defaulting to no-operation (NOP) logger implementation
[02:41:40 WARN]: SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
[02:41:40 INFO]: [QuickShop] Loading plugin translations files...
[02:41:40 INFO]: [QuickShop] Downloading version manifest...
[02:41:40 INFO]: [QuickShop] Downloading version index...
[02:41:41 WARN]: [QuickShop] Cannot get file hash for language en_us, fallback to en_us...
[02:41:41 WARN]: [QuickShop] Cannot download require files, some items/blocks/potions/enchs language will use default English name.
[02:41:41 INFO]: [QuickShop] Translator: Ghost_chu, Andre_601
[02:41:41 INFO]: [QuickShop] Contributors: Timtower, Netherfoam, KaiNoMood, Mgazul, JackTheChicken and Andre_601
[02:41:41 INFO]: [QuickShop] Language Zone: English (en_US)
[02:41:41 INFO]: [QuickShop] Completed to load plugin translations files.
[02:41:41 INFO]: [QuickShop] Starting loading items translation...
[02:41:41 INFO]: [QuickShop] Complete to load items translation.
[02:41:41 INFO]: [QuickShop] Starting loading enchantments translation...
[02:41:41 INFO]: [QuickShop] Complete to load enchantments translation.
[02:41:41 INFO]: [QuickShop] Starting loading potions translation...
[02:41:41 INFO]: [QuickShop] Complete to load potions effect translation.
[02:41:41 INFO]: [QuickShop] Successfully loaded OpenInv support!
[02:41:41 INFO]: [QuickShop] Successfully loaded PlaceHolderAPI support!
[02:41:41 INFO]: [QuickShop] Using Virtual item Display, loading ProtocolLib support...
[02:41:41 INFO]: [QuickShop] Successfully loaded ProtocolLib support!
[02:41:41 INFO]: [QuickShop] Selected permission provider: Bukkit
[02:41:41 INFO]: [QuickShop] Manager now selected: BukkitEventManager
[02:41:41 INFO]: [QuickShop] Loading shops from the database...
[02:41:41 INFO]: [QuickShop] Used 1ms to fetch all shops from the database.
[02:41:42 INFO]: [QuickShop] Successfully loaded 11 shops! (Used 112ms, Avg 10ms per shop)
[02:41:42 INFO]: [QuickShop] 4 shops will load after chunk have loaded, 0 shops will load after the world has loaded.
[02:41:42 INFO]: [QuickShop] Registering Listeners...
[02:41:42 INFO]: [QuickShop] Cleaning MsgUtils...
[02:41:42 INFO]: [QuickShop] Cleaning purchase messages from the database that are over a week old...
[02:41:42 INFO]: [QuickShop] QuickShop Loaded! 1421 ms.
[02:41:42 INFO]: [QuickShop] Log actions is enabled, actions will log in the qs.log file!
Ghost-chu commented 3 years ago

Try this build https://ci.codemc.io/job/Ghost-chu/job/QuickShop-Reremake-SNAPSHOT/556/

Kenaestic commented 3 years ago

Try this build https://ci.codemc.io/job/Ghost-chu/job/QuickShop-Reremake-SNAPSHOT/556/

That didn't work :/

Ghost-chu commented 3 years ago

pretty sure this one working for you https://ci.codemc.io/job/Ghost-chu/job/QuickShop-Reremake-SNAPSHOT/557/

Kenaestic commented 3 years ago

It does! Thank you.