[BUG] Remove command description if the player does not have permission

SrBedrock commented 3 years ago

Describe the bug:

Players without permission for /qs removeall, /qs info and /qs about can see the command with /qs help

To Reproduce:

Steps to reproduce the behavior:

Remove quickshop.removeall, quickshop.removeall.self, quickshop.removeall.others, quickshop.about and quickshop.about from players.
Use /qs help

Expected behavior:

Players do not see command descriptions that they do not have permission.

Screenshots:

Ghost-chu commented 3 years ago

We won't show command help/tabcomplete if player had no permissions. Cannot reproduce this issue on test server, check your permission configuration.

To troubleshooting permissions issue, you can use /qs debug to enable debug logger and see permissions verbose.

SrBedrock commented 3 years ago

I performed the test after activating the debug with /qs debug

QuickShop version: 4.0.7.10 LuckPerms version: 5.3.21

Permission check by LuckPerms:

quickshop.removeall: https://gist.github.com/SrBedrock/2ed5ff533f493cca6ef9ac18d44b98e7
quickshop.removeall.self: https://gist.github.com/SrBedrock/90408b44b91072f8940c0864858bfe6e
quickshop.removeall.other: https://gist.github.com/SrBedrock/d58782f0d6dc8e3b87463f54d485b18c

Player Koyote using the /qs about:

QS Debug Link: https://gist.github.com/SrBedrock/ddeacf7644ab109bb5fe768ce399c7a5
Image: https://i.imgur.com/k5J0jFA.png

Player Koyote using the /qs removeall:

QS Debug Link: https://gist.github.com/SrBedrock/319ca5b55ba2db63a4bff4fa5ce994a0
Error: "no-owner-given": "&cNo owner provided"
No calculation is performed by the server, no lag.

Player Koyote using the /qs removeall Koyote:

QS Debug Link: https://gist.github.com/SrBedrock/60ab5a7f3dbfa68fa739727bbcd71a8f
Error: "no-permission": "&cYou do not have permission to do that."
Some calculation is performed because the error takes a long time to return. (lag server)
Lag Spike: [⚡] Tick #26715 lasted 5500.97 ms. (10901.93% increase from avg)
Image: https://i.imgur.com/kktoEw3.png
Spark Link: https://spark.lucko.me/UkdlDUxtcA

Player Koyote using the /qs removeall ThiagoROX:

QS Debug Link: https://gist.github.com/SrBedrock/96acf4390bd213e118f09935c83c7045
Error: "no-permission": "&cYou do not have permission to do that."
Some calculation is performed because the error takes a long time to return. (lag server)
Lag Spike: [⚡] Tick #2546 lasted 3631.78 ms. (7163.55% increase from avg)
Spark Link: https://spark.lucko.me/VcbgD3TwFg

Additional context when disabling debug mode::

[QuickShop] Loading shops from the database...
[QuickShop] Used 0ms to fetch all shops from the database.
[QuickShop] Successfully loaded 5904 shops! (Used 2174ms, Avg 0ms per shop)
[QuickShop] 5903 shops will load after chunk have loaded, 0 shops will load after the world has loaded.
[QuickShop] Registering Listeners...
[QuickShop] Cleaning MsgUtils...
[QuickShop] Cleaning purchase messages from the database that are over a week old...
[QuickShop] QuickShop Loaded! 2429 ms.
[QuickShop] Log actions is enabled, actions will log in the qs.log file!
[QuickShop] Registering GriefPrevention integration
[QuickShop] Registering WorldGuard integration
Modo Developer desativado. Recarregando QuickShop.
[QuickShop] Registering bStats metrics...
[QuickShop] You have disabled mertics, Skipping...
[QuickShop] Using economy system: Essentials Economy
[⚡] Tick #55048 lasted 2453.4 ms. (4806.78% increase from avg)

SrBedrock commented 3 years ago

New server with:

Command /qs paste: https://paste.ubuntu.com/p/7mhpH4yr8B/

Command /qs:

TabComplete /qs remove...:

Command /qs removeall:

TabComplete /qs removeall ...:

Command /qs removeall ThiagoROX:

Ghost-chu commented 3 years ago

/qs removeall and /qs removeall <player> is two different command.

---Original--- From: @.> Date: Wed, Apr 14, 2021 16:51 PM To: @.>; Cc: @.>;"State @.>; Subject: Re: [Ghost-chu/QuickShop-Reremake] [BUG] Remove command description if the player does not have permission (#910)

New server with:

Command /qs:

TabComplete /qs remove...:

Command /qs removeall:

TabComplete /qs removeall ...:

Command /qs removeall ThiagoROX:

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

Ghost-chu commented 3 years ago

Please provide link created by command /qs paste

Ghost-chu commented 3 years ago

Yes, /qs reload will cause server lag because it will unload and load again plugin self to reloading.

Ghost-chu commented 3 years ago

also we recommend get support through our discord server because this issue seems too complex.

SrBedrock commented 3 years ago

I contacted via discord and my problem will be solved, thanks

Ghost-chu / QuickShop-Reremake