search

GhostPack / Rubeus

Trying to tame the three-headed dog.
Other
4.11k stars 778 forks source link

Allow exporting tickets to full paths #101

Closed VbScrub closed 2 years ago

VbScrub commented 2 years ago

Fixes #76 and fixes #63

Tested with asktgt and the following paths as the /outfile argument and all works as it should:

C:\test\ticket.txt \ticket.txt C:\invalid/chars*.txt - file gets written to C:\invalid_chars_.txt invalid/chars*.txt - file gets written to invalid_chars_.txt in working directory

For the record I still think we should ditch the whole file name sanitization thing, especially as it is not used universally throughout the program (kerberoasting for example does not sanitize file names, so that already let you use full paths for /outfile).

0xe7 commented 2 years ago

It looks like a bunch of these commits aren't related to the PR. Also you can't change Rubeus' OutputType from Exe to WinExe (commit 6475e7e).

VbScrub commented 2 years ago

Sorry I'm still relatively new to github and I guess I've done something weird earlier today whilst trying to fork Rubeus for the GUI I'm working on. No idea how that ended up affecting this PR I made a week ago but yeah there was only meant to be one file changed in this PR. EDIT: I've created a new PR now that is in a separate branch, so I think that should stop this happening again?