[fb-bots] fix default response to user typing

[rhwy]

Request : Billy [18:26] on slack

our messenger bots currently break quite badly when the user types anything for example: me and andreas made a new bot- artbuddy, yesterday if I don't type anything (aside from the first "hi") the bot works fine, but if I type even once after that, the bot will send me a random image and then stop doing anything (plays no more steps) this is a real issue for when we try to validate our bots with Facebook - the testers will certainly try to type how can we fix this?

[rhwy]

There is already something implemented for that but that need to be better defined. as we can see in dev master https://github.com/GhostWording/gw-config-apis/blob/master/data/bot/apps/surveypony/Dev-SequencesMasterConfig.json

we have a new section that could be used for that "FragmentForUnknownCommand":"/data/bot/sequences/smalltalk/AreYouHuman.json".

Next steps:

• [rui] : verify where and how this behavior is actually implemented
• [rui] : report it here
• [all] : adjust the behavior if needed

[rhwy]

this is the actual behavior on the bot engine:

• Try

  • if user input
    • is Menu click -> then continue with sequences
    • is notify conversation -> then execute the notify (for automated messages)
    • is an admin bot command -> then execute admin command
    • is an admin history command -> then execute history command (clear history)
    • is admin profile command -> clear profile
    • is admin conversation command -> clear conversation
    • is a bad admin command (=something that starts with cmd: but unknown -> show admin error
    • is start conversation command -> then show welcome message, send user event and start sequences
    • is set location command -> then execute set location action and continue with next sequence
    • is image, sticker (or any other file) -> then show thank you and continue with next sequence
    • is a like -> then return like action, return thank you and continue with next sequence
    • is a known typed keyword -> send user event for keyword, execute sequence associated with fragment and then continue with next sequence
    • is free text ->
      • if text = "location" then show set location button
        • else -> send user event with free text and
          • if seq master file contains FragmentForUnknownCommand then show the sequence defined here
          • else try to find and show card for input
        • continue with next sequence
  • in any other cases, continue with next sequence

• on error:

  • log error and do nothing

[andreasdieryck]

Note:

• I was able to set a FragmentForUnknownCommand in our latest Messenger bot (Art Buddy)
• it works as expected

One thing worth noting:

• until now, the sequence /data/bot/sequences/smalltalk/AreYouHuman.jsonwas used as the default fragment for FragmentForUnknownCommand...
• ... but it wasn't listed as a fragment :)

From Slack: https://wavemining.slack.com/archives/C96TSRCHE/p1548078102002500