GhostWording / gw-config-apis

this repo contains static json that can live through apis with github management only
0 stars 7 forks source link

issue with randomising fragments by tags #49

Open BillyWaveM opened 5 years ago

BillyWaveM commented 5 years ago

it seems that when we call for a fragment by tag, there is a situation in which we don't get a random fragment.

I set up a test which calls for a fragment by tag (billytesttag3) (this sequence https://github.com/GhostWording/gw-config-apis/blob/master/data/bot/sequences/experiments/Billy2/randomisefragmentstagstest.json)

two sequences have this tag https://github.com/GhostWording/gw-config-apis/blob/master/data/bot/sequences/experiments/Billy2/billytesttag3firstfrag.json https://github.com/GhostWording/gw-config-apis/blob/master/data/bot/sequences/experiments/Billy2/billytesttag3secondfrag.json

I expected to get an equal distribution of these fragments when calling for the tag billytesttag3. instead, I got billytesttag3firstfrag every time. http://gw-bot-apis.azurewebsites.net/api/sequences/fragment { "BotName":"billy2019test", "DeviceId": "edcdscg", "FacebookId":"defg", "Tags": ["billytesttag3"] } Andreas hypothesised that this was due to the IDs being similar, so created a third fragment with the same tag, but with a very different ID (MyAwesomeTest) https://github.com/GhostWording/gw-config-apis/blob/master/data/bot/sequences/experiments/Andreas/MyAwesomeTest.json

after this, we receive an equal distribution of billytesttag3firstfrag and MyAwesomeTest, and still no billytesttag3secondfrag

is it possible that randomisation between the first two sequences was impossible because the sequence IDs were too similar? can anything be done about this?

Thanks