GhostWriters / DockSTARTer

DockSTARTer helps you get started with running apps in Docker.
https://dockstarter.com/
MIT License
2.24k stars 229 forks source link

NPM Compose Override Volumes inconsistent with .env defaults #1795

Closed grebz-dev closed 1 month ago

grebz-dev commented 1 month ago

https://github.com/GhostWriters/DockSTARTer/blob/b6c16361d7c7749ffe8aeecafa18d36fc2ceda25/docs/overrides/nginxproxymanager.md?plain=1#L42-L45

These lines need to be updated to:

      - ${DOCKERCONFDIR}/proxymanager/config.json:/app/config/config.json
      - ${DOCKERCONFDIR}/proxymanager/data:/data
      - ${DOCKERCONFDIR}/proxymanager/letsencrypt:/etc/letsencrypt
      - ${DOCKERSTORAGEDIR}:/storage
CLHatch commented 1 month ago

https://github.com/GhostWriters/DockSTARTer/blob/b6c16361d7c7749ffe8aeecafa18d36fc2ceda25/docs/overrides/nginxproxymanager.md?plain=1#L42-L45

These lines need to be updated to:

      - ${DOCKERCONFDIR}/proxymanager/config.json:/app/config/config.json
      - ${DOCKERCONFDIR}/proxymanager/data:/data
      - ${DOCKERCONFDIR}/proxymanager/letsencrypt:/etc/letsencrypt
      - ${DOCKERSTORAGEDIR}:/storage

Actually, those variables have been renamed to the DOCKER_VOLUME_* ones in a major update that came out recently. You'll see this next time you do a ds -u.

Edit: You'll have to manually change any references to those variables in your docker-compose.override.yml file if you have one. They'll be updated in your .env for you though.

grebz-dev commented 1 month ago

My mistake!