Closed altrisi closed 3 years ago
Look, I know you don't like prolonging prs, but imma wait on this one. If you want, you keep on working on this one without updating from master, and Ill fix conflicts right when merging. This is cos im super busy personally, also cos I dont like having to depend on unreleased versions of fabric-carpet, especially as the split() bug is still in there as of now, and idk when its gonna be fixed. Ill mark this as a draft till then.
Don't worry, it makes sense. Hopefully it's fixed before next release. I just sent the PR already so it can be reviewed/tested/checked with more time.
Ill merge when next release of fc comes out which adds the json stuff.
Would you mind editing collaborate.md to describe how to add a translation and properly use the _print()
command?
Added.
Note: This has had 3 approvals since over 10 days ago. Can I/someone click the merge button?
I'll carefully fix conflicts in other PRs after that.
Yes plz. I just didn't dare do it myself.
ye It's good to be merged now. Ill then fix conflicts with the other pr, and then release v1.2
This PR overhauls the way translations work in the app in order to not be hardcoded to specific languages but load dynamically based on the
langs
folder contents.As a summary, this PR:
/world-edit lang
without argumentsen_us
language file on startup to be usable as a template to create other languages (async, cause why not)it_it
language file (it was a lot worse, but I was tired after reordering all language keys)%
symbol being required to be passed as a param: To escape it in Java, you need to use%%
Since the app no longer knows the completeness of every language (those are dynamic), it will check the list of non-present keys in an async task when the language is selected, and it will log the full list of entries to the log as a
WARN
.As an extra, it also fixes the selection not being properly displayed in the help menu since Selection v2.
New/touched yet untranslated lang strings:
langs_*