Ghoulboy78 / Scarpet-edit

A useful tool for developing decorative builds etc in scarpet.
Creative Commons Zero v1.0 Universal
22 stars 4 forks source link

Translations v2 #31

Closed altrisi closed 3 years ago

altrisi commented 3 years ago

This PR overhauls the way translations work in the app in order to not be hardcoded to specific languages but load dynamically based on the langs folder contents.

As a summary, this PR:

Since the app no longer knows the completeness of every language (those are dynamic), it will check the list of non-present keys in an async task when the language is selected, and it will log the full list of entries to the log as a WARN.

As an extra, it also fixes the selection not being properly displayed in the help menu since Selection v2.

New/touched yet untranslated lang strings:

Ghoulboy78 commented 3 years ago

Look, I know you don't like prolonging prs, but imma wait on this one. If you want, you keep on working on this one without updating from master, and Ill fix conflicts right when merging. This is cos im super busy personally, also cos I dont like having to depend on unreleased versions of fabric-carpet, especially as the split() bug is still in there as of now, and idk when its gonna be fixed. Ill mark this as a draft till then.

altrisi commented 3 years ago

Don't worry, it makes sense. Hopefully it's fixed before next release. I just sent the PR already so it can be reviewed/tested/checked with more time.

Ghoulboy78 commented 3 years ago

Ill merge when next release of fc comes out which adds the json stuff.

Firigion commented 3 years ago

Would you mind editing collaborate.md to describe how to add a translation and properly use the _print() command?

altrisi commented 3 years ago

Added.

altrisi commented 3 years ago

Note: This has had 3 approvals since over 10 days ago. Can I/someone click the merge button?

I'll carefully fix conflicts in other PRs after that.

Firigion commented 3 years ago

Yes plz. I just didn't dare do it myself.

Ghoulboy78 commented 3 years ago

ye It's good to be merged now. Ill then fix conflicts with the other pr, and then release v1.2