Some shapes are broken after merge of #49

Ghoulboy78 / Scarpet-edit

A useful tool for developing decorative builds etc in scarpet.

Creative Commons Zero v1.0 Universal

22 stars 4 forks source link

Closed Firigion closed 2 years ago

Firigion commented 3 years ago

[ ] Cylinder, Cone and Pyramid with special orientations don't work at all (they don't place blocks)
[ ] Cone creates pyramids, and pyramids have uneven slopes (here you can see 3 blocks at the bottom and the steps of one, instead of the expected two steps of two):
[ ] Hollow ellipsoid has holes:
[x] Hollow cuboid has strange shape:
[ ] Hollow cube is very broken:
[ ] Shpere is not isotropic (symmetrical):

Don't fix what ain't broke, and if you do, make sure the fix works...

Ghoulboy78 commented 3 years ago

I think most of these can be fixed when I rewrite them after gnembon/fabric-carpet#742 is accepted.

Ghoulboy78 commented 3 years ago

except for ellipsoid, which is borked differently, but I think I can fix that aswell