Undo and set bugfixes, and entity handling

Ghoulboy78 / Scarpet-edit

A useful tool for developing decorative builds etc in scarpet.

Creative Commons Zero v1.0 Universal

22 stars 4 forks source link

Undo and set bugfixes, and entity handling #67

Closed Firigion closed 3 years ago

Firigion commented 3 years ago

Fixes #57 and fixes #50 with the solutions proposed in each bugreport.

Ghoulboy78 commented 3 years ago

hmm, your fix for the set now makes it so if I set a block with the same state as before, it still thinks that many blocks changed.

Firigion commented 3 years ago

Woops, I forgot to check that. I'll see what's up.

Firigion commented 3 years ago

I need to be more moderate and make multiple PRs. Sorry, people :/

altrisi commented 3 years ago

Did the minimum review count change? (should I merge it?)

Firigion commented 3 years ago

It changed when the activity here lowered and fewer people were reviewing stuff. Two reviews meant that the whole active team had to agree, since there were only three of us ding stuff :P Idk if it was the right decission, but it was the only way to keep developing the app in the meantime. I don't recall this having any bugs, so it's good to merge, as far as I'm concerned. Idk if you tested or not tho...

altrisi commented 3 years ago

Yes I tested it back in my previous review and again today. I'll merge it, if it breaks, it can be fixed SoonTM.