search

Ghoulboy78 / Scarpet-edit

A useful tool for developing decorative builds etc in scarpet.
Creative Commons Zero v1.0 Universal
22 stars 4 forks source link

Added zh_cn.json for Simplified Chinese #89

Closed Pairman closed 2 years ago

Pairman commented 3 years ago

Added zh_cn.json for Simplified Chinese language. I'm not a specialist at doing translations and I've barely used worldedits, therefore I completed this translation file under the help of many documents about worldedit commands. The translation style is not too consistent with the en_us.json. I've tried my best.

Ghoulboy78 commented 3 years ago

Well to be honest it's not like we have anyone who speaks any Chinese on the main dev team, so idk what to do with this. (to the developers) should we approve this, or ask someone who speaks Chinese to come review?

altrisi commented 3 years ago

I think as long as everything appears translated and works (not throwing errors on placeholders) we should trust them. If it was just some random easy form or something like that it would be less trustable, but making a PR is not as easy as that.

Plus some of the systems using many translations (mainly help menu) are really in need of upgrading (in my TO-DO list), but hopefully it shouldn't affect this (here meaning that it would be difficult for machines to make acceptable translations of some strings).

Just to be sure I don't break things in my translations v2.1 update: There's no problem if at some point we remove the _cn suffix and just keep it as zh, right? (will be changed when I get to finish #88)

Thanks! Will review things don't throw Soon™

Pairman commented 3 years ago

I think as long as everything appears translated and works (not throwing errors on placeholders) we should trust them. If it was just some random easy form or something like that it would be less trustable, but making a PR is not as easy as that.

Plus some of the systems using many translations (mainly help menu) are really in need of upgrading (in my TO-DO list), but hopefully it shouldn't affect this (here meaning that it would be difficult for machines to make acceptable translations of some strings).

Just to be sure I don't break things in my translations v2.1 update: There's no problem if at some point we remove the _cn suffix and just keep it as zh, right? (will be changed when I get to finish #88)

Thanks! Will review things don't throw Soon™

Feel free to change the filename