search

Ghoulboy78 / Scarpet-edit

A useful tool for developing decorative builds etc in scarpet.
Creative Commons Zero v1.0 Universal
22 stars 4 forks source link

I find some bugs #91

Open ch-yx opened 2 years ago

ch-yx commented 2 years ago

https://github.com/gnembon/fabric-carpet/issues/1118#issuecomment-927389553

@altrisi thanks you. but after my reading and testing that script, i find some issues.

https://github.com/Ghoulboy78/Scarpet-edit/blob/64543f220242657c0086c20a4ccfb138bc7dcce5/se.sc#L1943-L1945

seems that the area is not correct. maybe pos2=pos2+1 could fix that ?

https://github.com/Ghoulboy78/Scarpet-edit/blob/64543f220242657c0086c20a4ccfb138bc7dcce5/se.sc#L1957-L1961

seems that the one who writes the code incorrectly assumes that the map will remain its order.

https://github.com/Ghoulboy78/Scarpet-edit/blob/64543f220242657c0086c20a4ccfb138bc7dcce5/se.sc#L1963

I am concerned that the unnecessary use of parse_nbt here will disrupt some of the nbt types.

Ghoulboy78 commented 2 years ago

Ye... that part of the code is overdue for a rewrite anyways... We just havent had the time. I have fixed some of the issues on a private branch that I haven't touched for a while.