search

Ghoulboy78 / Scarpet-edit

A useful tool for developing decorative builds etc in scarpet.
Creative Commons Zero v1.0 Universal
22 stars 4 forks source link

Updating shapes to use shapes.scl and fix some minor things #94

Open Ghoulboy78 opened 2 years ago

Ghoulboy78 commented 2 years ago

It replaces cuboid, cylinder, sphere, cone and pyramid with shapes.scl equivalents. Obviously it will work better when https://github.com/gnembon/fabric-carpet/pull/1154 is accepted, and cuboid does actually need to be reverted and the old code fixed.

Ghoulboy78 commented 2 years ago

Is this working off of your suggested changes to shapes.scl in gnembon/fabric-carpet#1154? Because right now it doesn't work with the current shapes.scl. I'd also like to know it that PR depends on gnembon/fabric-carpet#1218, because as discusse on Discord, it doesn't look like perople are gonna agree on implementing your suggested changes...

This is indeed working off of my changes to shapes.scl in gnembon/fabric-carpet#1154, as mentioned in the title, but gnembon/fabric-carpet#1218 has got nothing to do with this, because gnembon/fabric-carpet#1154 uses a workaround so I don't have to use it. I will merge this pr after gnembon/fabric-carpet#1154 gets merged and sent into a release, so you have time to review, especilly cos now I0ve got a lot more work to do on that one.

altrisi commented 2 years ago

One thing that could be done is adding the newer Carpet version in a requires block too, so we make sure things will work correctly.

Ghoulboy78 commented 2 years ago

I'm afraid I don't really know how 'requires' works, so I couldn't do it myself...