No tank spawn on c8m1_apartment

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Confogl sets the Convars for versus boss spawn intro
2. Load up confogl on No Mercy
3. A witch is guaranteed to spawn instead of the tank

What is the expected output? What do you see instead?
A tank instead of a witch. 

What version of the product are you using? On what operating system?
Version 2.2.1, Windows. 

I did a quick test and set the witch_spawn_intro to 0, tank_spawn_intro to 1 on 
a local server and the problem still occurred.

It seems like the map is like c1m1_hotel, or the finale of hard rain that 
prevents a tank spawn. But why a witch is able to even though the chance is set 
to 0% I don't know. 

Tried a stripper dump for the sake of it, didn't find anything. 

Original issue reported on code.google.com by blakelue...@gmail.com on 7 Oct 2010 at 1:15

[GoogleCodeExporter]

The game does have some ways to override ConVar settings using vscripts (like 
how it can prohibit boss spawning).  I don't know if it just reads those or if 
it actually sets the ConVars (aka if we can see the change or not).  I do know 
that in L4D1, No Mercy was such a short map that due to minimum boss padding 
you could not have a tank AND a witch so I believe the problem is not "no 
tanks" but is actually "forced witches".  Possible fix: block the L4DT forward 
for witches and see if a tank spawns?

Original comment by Canada.R...@gmail.com on 7 Oct 2010 at 4:59

• Changed state: Accepted

[GoogleCodeExporter]

No tank on Interior (c8m4_interior) either. bleh. Same problem, just forces the 
witch. 

Original comment by blakelue...@gmail.com on 7 Oct 2010 at 6:35

[GoogleCodeExporter]

I've been told that setting
versus_boss_padding_min 0.0
versus_boss_padding_max 0.0

Will make the tanks spawn. No idea what this will do on other maps.

Original comment by prodigysim@gmail.com on 7 Oct 2010 at 7:10

[GoogleCodeExporter]

Nope.avi

Original comment by Canada.R...@gmail.com on 8 Oct 2010 at 4:04

[GoogleCodeExporter]

This seems to also apply to c8m4 and c8m5.

Original comment by Canada.R...@gmail.com on 9 Oct 2010 at 2:52

[GoogleCodeExporter]

Tried setting:
versus_boss_padding_min 0.0
versus_boss_padding_max 0.0

but it didn't work on any of the No Mercy maps

Original comment by yumyudai on 9 Oct 2010 at 5:31

[GoogleCodeExporter]

c8m1 has DisallowThreatType set to THREAT_TANK in it's nut script. This can be 
overwritten. The other maps are still a mystery if padding doesn't help. Tell 
valve I guess :/

Original comment by prodigysim@gmail.com on 9 Oct 2010 at 6:36

[GoogleCodeExporter]

Finale could possibly be like c4m5 where the map is just too short to allow a 
tank (even if there could have been one in L4D1).  But c8m4 is definitely long 
enough to support both a tank and a witch with default padding. 

Original comment by Canada.R...@gmail.com on 10 Oct 2010 at 12:24

[GoogleCodeExporter]

Could it be that versus_tank_chance is set in the map?
I played No Mercy in a public game yesterday and the tank didn't spawn at all.

Original comment by yumyudai on 10 Oct 2010 at 1:36

[GoogleCodeExporter]

I found it today while looking for how to set L4D1 survivors for an addon 
campaign. In the mission txt files for Sacrifice and No Mercy, Valve introduced 
a new argument, called "versus_boss_spawning" that controls witch and tank 
chance, as well as flow min/max. Example is here, from No Mercy map 1 in the 
versus section:

"versus"
        {
            "1"
            {
                "Map" "c8m1_apartment"
                "DisplayName" "#L4D360UI_LevelName_VERSUS_C8M1"
                "Image" "maps/l4d_hospital01_apartment"
                "VersusCompletionScore" "400"
                "versus_boss_spawning"
                {
                    "spawn_pos_min" "0.30"
                    "spawn_pos_max" "0.90"
                    "tank_chance"   "0.00"
                    "witch_chance"  "1.00"
                }
            }
Also, the argument for L4D1 survivors is "survivor_set" "1" if anyone was 
curious. Set it to 2 for L4D2 survivors.

Original comment by abecker...@gmail.com on 11 Oct 2010 at 1:37

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

By editing the file and recompiling the vpk I was able to get the tank to spawn 
on Interior and the beginning of Rooftop. 

Apartment is still stubborn though, removed the witch, but the tank still won't 
spawn. 

Original comment by blakelue...@gmail.com on 11 Oct 2010 at 2:23

[GoogleCodeExporter]

If anyone is interested, the above mission files are on valve wiki here:
http://developer.valvesoftware.com/wiki/List_of_L4D2_Missions_Files

Original comment by yumyudai on 11 Oct 2010 at 5:43

[GoogleCodeExporter]

We can overwrite this through scripting and detours now that we know the source.

c8m1_apartment also sets a script value (c8m1_apartment.nuc) to Disallow tanks 
(DisallowThreatType = THREAT_TANK or somesuch). You could try deleting the nuc 
from the left4dead2_dlc2/ vpk. Or just wait for 2.2.2. 

Again, nice find and thanks for the heads up!

Original comment by prodigysim@gmail.com on 11 Oct 2010 at 8:37

• Changed state: Started

[GoogleCodeExporter]

I've confirmed that the tank spawns on all maps of No Mercy by editing the 
mission file and the vscript.
Now, just need to wait for ProdigySim to write a code for us that fixes this 
without the hard editing work :D

Original comment by yumyudai on 11 Oct 2010 at 9:25

[GoogleCodeExporter]

Left4Downtown repo now has some code to support this. I've made a rudimentary 
plugin using it here:

https://bitbucket.org/ProdigySim/misc-sourcemod-plugins/src/tip/bossspawningfix/
bossspawningfix.sp

Info on the new forward used can be found here:
http://code.google.com/p/left4downtown2/source/browse/scripting/include/left4dow
ntown.inc#217

Original comment by prodigysim@gmail.com on 12 Oct 2010 at 8:33

[GoogleCodeExporter]

I added that fix to unprohibit, and it all worked, and then I deleted it by 
mistake >.<

I'll get around to re-adding it when I'm done with CvarSettings.sp

Original comment by Canada.R...@gmail.com on 15 Oct 2010 at 6:07

[GoogleCodeExporter]

Original comment by Canada.R...@gmail.com on 15 Oct 2010 at 5:33

• Changed state: Fixed

[GoogleCodeExporter]

when can we get the fix for tanks for the no mercy maps?

Original comment by jiayon...@gmail.com on 17 Oct 2010 at 11:11