GiTA-Client / GiTA

A desktop application that both helps students learn git and helps teaching assistants assess repositories. (No longer maintained.)
GNU General Public License v3.0
3 stars 0 forks source link

Traffic lights always red on local repository issues #62

Open nanuaraj opened 6 years ago

nanuaraj commented 6 years ago

We want the traffic lights to turn yellow if they are not in sync with the remote branch, and red if updating the branch would cause a conflict. The mechanism for this is set up in js/trafficlights.js in gitUpdateCheck, gitUpdateCallback, gitMergeConflictCheck and gitMergeConflictCallback. gitUpdateCallback calls gitMergeConflictCheck. cmdOut should be set to empty string before gitMergeConflictCheck executes the command for checking merge conflicts. However, doing this in that function does not seem to clear cmdOut. We need further investigation on this issue to restore functionality for yellow lights, but this is likely related to gitMergeConflictCheck being called by an asynchronous function.