search

GiacomoPope / kyber-py

A pure python implementation of ML-KEM (FIPS 203) and CRYSTALS-Kyber
MIT License
183 stars 44 forks source link

Attempt to include coveralls #62

Closed GiacomoPope closed 1 month ago

GiacomoPope commented 1 month ago

Trying to make it work with: https://github.com/coverallsapp/coverage-reporter

GiacomoPope commented 1 month ago

So I think this is working now: https://coveralls.io/jobs/147503738 but I suppose I need some way to communicate this

GiacomoPope commented 1 month ago

@tomato42 seeing as this was your suggestion, do you have a "favourite way" to communicate the output from the CLI?

tomato42 commented 1 month ago

one tricky part is that after you create steps to upload the individual job results to coveralls, like so: https://github.com/tlsfuzzer/python-ecdsa/blob/35c33f2e11e6f95b16cec3fe0eaa5d0e34082b18/.github/workflows/ci.yml#L372-L385

you need to then tell coveralls that all jobs finished and the test run is ready: https://github.com/tlsfuzzer/python-ecdsa/blob/35c33f2e11e6f95b16cec3fe0eaa5d0e34082b18/.github/workflows/ci.yml#L387-L401

GiacomoPope commented 1 month ago

I'm finishing for the day now, I might pick this back up later. Feel free to tweak if you want.

tomato42 commented 1 month ago

Fixed it up.

GiacomoPope commented 1 month ago

Thanks for fixing this for me