GiampaoloGabba / Xamarin.Plugin.SharedTransitions

Shared Element Transitions between pages in Xamarin.Forms (IOS/Android)
MIT License
414 stars 57 forks source link

Does not seem to be compatible with new AndroidX versions of Forms #23

Closed RedChops closed 4 years ago

RedChops commented 4 years ago

Bug Information

Version Number of Plugin: 2.0.2 Device Tested On: Pixel 2 Emulator Simulator Tested On: iOS 13 simulator Version of VS: 2019 16.4.4 Version of Xamarin: 4.6.0.240-nightly Versions of other things you are using:

Steps to reproduce the Behavior

I don't know if this project is still active, it's not seeming so, but I can't build my solution with this plugin in it anymore.

RedChops commented 4 years ago

I know that I could add the assembly reference as specified above, but that doesn't make sense, as I don't use it in my application anywhere.

GiampaoloGabba commented 4 years ago

In the next few week i'll pubblish a new, updated, version that will target androix library, along with shell support. I'm going to have some free time to dedicate some more love to this puppy :)

vunhutien commented 4 years ago

Waiting for your release to support AndroidX and Tabpage, this puppy is so nice.

GiampaoloGabba commented 4 years ago

I have a working branch with multitargeting to androidX (using xf 4.5 and target api 29): here

I'm doing some test, if everything is ok i'll release a new version very soon

GiampaoloGabba commented 4 years ago

I have pubblished a pre-release nuget with Android X support.

To enable AndroidX support, use Xamarin.Forms 4.5+ and target API29.

This is my first AndroidX port, so i will leave it in pre-release for a few days, considering that the new version will still support Xaamarin.Forms 4.3 with old Android api (without AndroidX support, of course). I have to be sure that both functionalities (with androidx and without) are the same.

GiampaoloGabba commented 4 years ago

Going to pubblish a new release with AndroidX & other fixes very soon