search

GiampaoloGabba / Xamarin.Plugin.SharedTransitions

Shared Element Transitions between pages in Xamarin.Forms (IOS/Android)
MIT License
414 stars 57 forks source link

[Bug] Navigation.PopAsync(false) results in empty page #45

Closed Inrego closed 3 years ago

Inrego commented 3 years ago

Bug Information

Version Number of Plugin: 2.3.0 Device Tested On: Android 10.0 Simulator Tested On: Nope Version of VS: VS 2019 Version of Xamarin: 4.8.0.1269 Versions of other things you are using:

Steps to reproduce the Behavior

Call Navigation.PopAsync(false);

Expected Behavior

Page is popped without any animations

Actual Behavior

Page is popped, but now the current page is empty.

VladimirFelix commented 3 years ago

I had the same issue but only in iOS devices, also if I go back with a gesture the animation is beggin and if go back with pop the animations don't work. In Android works fine.

ezgif com-resize

ezgif com-video-to-gif

GiampaoloGabba commented 3 years ago

ok, i think that disabling the animation will disable entirely my custom delegate, so the view that got animated are not getting rendered, i can fix that.

@VladimirFelix do you have the same problem or your is different? To be clear, hwne you pop get a blank page, or when you pop the backwards animation doesnt start and there is the standard animation instead?

GiampaoloGabba commented 3 years ago

the non-animated pop is fixed in the next version.

@VladimirFelix regarding your issue with iOS i cant reproduce it. Would you mind to open a new issue and post a repro? Thx!

GiampaoloGabba commented 3 years ago

ok, if ound the issue in iOS, it's happening with shell. opening a new issue

VladimirFelix commented 3 years ago

ok, if ound the issue in iOS, it's happening with shell. opening a new issue

yes, I’m using shell :)

GiampaoloGabba commented 3 years ago

Oh man... with the new xf updates pop & gesture are complety broken... trying to find a way to fix it but everything in xf is internal and is a real challenge trying to work with an api like this....

Da: Hugo Vladimir Felix Anaya notifications@github.com Inviato: Sunday, September 27, 2020 9:35:06 PM A: GiampaoloGabba/Xamarin.Plugin.SharedTransitions Xamarin.Plugin.SharedTransitions@noreply.github.com Cc: Giampaolo Gabba info@evolutionlab.it; State change state_change@noreply.github.com Oggetto: Re: [GiampaoloGabba/Xamarin.Plugin.SharedTransitions] [Bug] Navigation.PopAsync(false) results in empty page (#45)

ok, if ound the issue in iOS, it's happening with shell. opening a new issue

yes, I’m using shell :)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/GiampaoloGabba/Xamarin.Plugin.SharedTransitions/issues/45#issuecomment-699678382, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB7PC2JSTFTU4ZOAZ2HTPZ3SH6HWVANCNFSM4QO7VD3Q.