search

Gibberlings3 / TalentsOfFaerun

6 stars 5 forks source link

SFO Bug/Compatibility with MIH_SP: Update ui_spell_system_elemental.tph #8

Closed SarahG-579462 closed 2 months ago

SarahG-579462 commented 2 months ago

Hey there ! I had an issue with the install for this. Surprised myself catching this one so quickly. Kinda proud of myself tbh.

Issue: dw_talents : bloodline sorcerers wouldn't install due to a conflict with MIH_SP, with their spell sunburst (SPWI827). 

[./override/SPWI827.spl] loaded, 634 bytes
Copying and patching 1 file ...
Copying and patching 1 file ...
[./override/MH#SUNBU.eff] loaded, 272 bytes
ERROR: illegal 2-byte read from offset 548 of 272-byte file MH#SUNBU.eff
ERROR: [MH#SUNBU.eff] -> [nowhere] Patching Failed (COPY) (Failure("MH#SUNBU.eff: read out of bounds"))
Stopping installation because of error.
ERROR: [SPWI827.spl] -> [nowhere] Patching Failed (COPY) (Failure("MH#SUNBU.eff: read out of bounds"))
Stopping installation because of error.

Looks like it's one of the only spells that goes through most of the logic for analyse_elemental_type. There was a typo on line 274: fx_off should be resource_offset.

DavidMWWallace commented 2 months ago

Thanks; right problem, though not quite right fix (it's slightly more substantial). Fixed locally, will be in next version.

AngelGryph commented 2 months ago

Using my unreleased master code together with ToF. Brave. Very brave. :laughing:

SarahG-579462 commented 2 months ago

Thanks; right problem, though not quite right fix (it's slightly more substantial). Fixed locally, will be in next version.

huh, weird that it was able to be installed with this fix for me, although maybe it messed something up elsewhere.

Using my unreleased master code together with ToF. Brave. Very brave. 😆

hehe, you don't want to know the size of my weidu.log file...