GibbonEdu / core

Gibbon is a flexible, open source school management platform designed to make life better for teachers, students, parents and leaders.
https://gibbonedu.org
GNU General Public License v3.0
482 stars 306 forks source link

Bug: Copy to next Year #1632

Closed KelvinMW closed 2 years ago

KelvinMW commented 2 years ago

Describe the Bug

The function copy to next year under school admin>> Manage Form groups does not check for duplicate of form group short name and if copy to next year is clicked multiple times it populates next year with duplicate form groups

To Reproduce

Go to : School Admin on Left side Menu: Manage Form Group then Click copy Form Group to next year (click several times)

Expected behavior

To detect multiple Duplicates of Form Groups in that Year(current-year+1) to avoid duplicates on the (current-year+1) academic year.

Actual behavior

Duplicates are produced when you switch to (current-year+1)

Screenshots

No response

Gibbon version

v24

Browser

No response

Browser Version

No response

Additional Context

No response

SKuipers commented 2 years ago

Hi Kelvin, thanks for the heads up! I've fixed this in v25 in the following commit, which is backwards compatible to v24: https://github.com/GibbonEdu/core/commit/09289a53743457122a6b44a1671a5eedcf938baa