GibbonEdu / core

Gibbon is a flexible, open source school management platform designed to make life better for teachers, students, parents and leaders.
https://gibbonedu.org
GNU General Public License v3.0
462 stars 301 forks source link

Messenger: add Save Draft and Preview features #1660

Closed SKuipers closed 1 year ago

SKuipers commented 1 year ago

This PR makes some major usability changes the the New Message functionality in Messenger, adding save draft, test email, and preview features. In the back end, scripts have been refactored, the New Message and Edit Message pages now share the same form, and the giant "messenger_postProcess.php" file is no more. There are parts of the giant send process that I have intentionally not refactored, with the aim to not introduce too many possible bugs in this already large change set.

Description

Motivation and Context Messenger can be powerful yet daunting for users. These features aim to make it easier to use and less intimidating by giving more previews and checks before sending a message.

How Has This Been Tested? Locally.

Screenshots

Screen Shot 2022-10-02 at 12 56 15 PM Screen Shot 2022-10-02 at 1 07 47 PM Screen Shot 2022-10-02 at 1 08 27 PM Screen Shot 2022-10-03 at 10 40 52 AM
rossdotparker commented 1 year ago

This is a massive chunk of work, and some much needed refactoring in what has become a rather unwieldy script. I've reviewed it, and can't see anything amiss. I'm going to merge now, and will then test locally.