Timetable Admin: refactor to use Url class for paths and url generation

GibbonEdu / core

Gibbon is a flexible, open source school management platform designed to make life better for teachers, students, parents and leaders.

https://gibbonedu.org

GNU General Public License v3.0

479 stars 304 forks source link

Timetable Admin: refactor to use Url class for paths and url generation #1674

Open yookoala opened 2 years ago

yookoala commented 2 years ago

Description

Use __DIR__ and require_once for a more stable behaviour when routed through index.php.
Refactor to use Url class for paths and url generation.

Motivation and Context

Remove the use of $session->get('absoluteURL') from the module.
Fix all issue when using Timetable Admin through index.php routing. Some feature was still relying on direct routing on the script path.
Pave way for future router routing efforts.

How Has This Been Tested?

CI environment.

yookoala commented 2 years ago

I think in long term, all the corner cases of the problem scripts need to be refactor so they works within index.php routing environment. Only then we can really migrate to path based routing (instead of script file based). It is strange that the form submit target cannot be routed from index.php.

I'm going to use the Crowd Assessment module as a test bed to try things out first. It is one of the smallest modules in Gibbon. Things should be simpler with it than the bigger ones. And before that, I'll need a better test coverage to the module.