Refactor password policy

GibbonEdu / core

Gibbon is a flexible, open source school management platform designed to make life better for teachers, students, parents and leaders.

https://gibbonedu.org

GNU General Public License v3.0

462 stars 300 forks source link

Refactor password policy #1685

Closed yookoala closed 1 year ago

yookoala commented 1 year ago

Description

A new abstraction PasswordPolicy to describe password policies with.
Have CoreServiceProvider setup to initialize PasswordPolicy from settings gateway.
Rewrite doesPasswordMatchPolicy and getPasswordPolicy with PasswordPolicy. Also mark both as deprecated.

Motivation and Context

To simplify code related to password policies.
Pave way to better error message with password policies.

How Has This Been Tested?

Locally.
CI environment.

yookoala commented 1 year ago

@SKuipers: Renamed.

yookoala commented 1 year ago

Thanks, looking great! Historically, the randomPassword function has generated passwords that did not match the policy. Now that we have this class, when we go to refactor randomPassword, we could add a PasswordPolicy::generatePassword method, so we could ensure that the passwords generated satisfied the policy smile

Sounds like a cool addition to the class. Will work on that.