System: deprecate randomPassword

GibbonEdu / core

Gibbon is a flexible, open source school management platform designed to make life better for teachers, students, parents and leaders.

https://gibbonedu.org

GNU General Public License v3.0

462 stars 300 forks source link

Closed yookoala closed 1 year ago

yookoala commented 1 year ago

Description

Add a new PasswordPolicy::generate method to generate a random password that's conforming to the rules defined for the instance.
Rewrite all randomPassword usages with PasswordPolicy::generate().

Motivation and Context

Fix issue when randomly generated password doesn't meet site password policy settings.
Deprecate usage of randomPassword.

How Has This Been Tested?

yookoala commented 1 year ago

@SKuipers: Just found an issue with phpstan and pushed 1 more commit. Please check and approve this again. Thanks.

SKuipers commented 1 year ago

@SKuipers: Just found an issue with phpstan and pushed 1 more commit. Please check and approve this again. Thanks.

Excellent, love that static analysis 😁 Thanks for catching this!

SKuipers commented 1 year ago

🎉 PR number 1700 🎉