search

GibbonEdu / core

Gibbon is a flexible, open source school management platform designed to make life better for teachers, students, parents and leaders.
https://gibbonedu.org
GNU General Public License v3.0
462 stars 300 forks source link

Selection component bug fix #1713

Closed leofreitas closed 1 year ago

leofreitas commented 1 year ago

Motivation and Context When a user uses another language some functionalities have a strange behavior. For example, the feature that make form fields hidden while form type is not selected. Because in the code the value should be 'Please select...'

How Has This Been Tested? Local

Screenshots Captura de Tela 2023-01-15 às 22 34 58

SKuipers commented 1 year ago

Hi Leo, here is the follow up commit: https://github.com/GibbonEdu/core/commit/d782cc1c04b5f4f1724cd4b59be90358d7eb8808

There were two additional cases that I fixed, one where the script was manually defining the placeholder string, which wasn't necessary as this is handled internally. The other was the visibility triggers whenNot() that needed to now check using the untranslated string. Have a quick look and let me know if you spot any issues. Thanks!