GibbonEdu / core

Gibbon is a flexible, open source school management platform designed to make life better for teachers, students, parents and leaders.
https://gibbonedu.org
GNU General Public License v3.0
479 stars 304 forks source link

Messenger's Home Screen Widget breaks the render of the sidebar #1718

Closed taha-mahmoud-ly closed 1 year ago

taha-mahmoud-ly commented 1 year ago

Describe the Bug

When the Home Screen Widget is enabled in the MESSAGE WALL SETTINGS ( School Admin >> Messanger Settings ), The Home screen sidebar fails to render, giving a warning of something escaped.

To Reproduce

  1. go to Admin >> School Admin >> Messanger Settings >> MESSAGE WALL SETTINGS >> enable Home Screen Widget

Expected behavior

The message walls appear on the sidebar as a quick preview.

Actual behavior

The sidebar fails to render. checking the logs it shows this error

FastCGI sent in stderr: "PHP message: Uncaught Exception: InvalidArgumentException - Query and fragment must be a string in /var/www/html/vendor/guzzlehttp/psr7/src/Uri.php on line 772"

Screenshots

No response

Gibbon version

V25

Browser

None

Browser Version

No response

Additional Context

disabling the homescreen widget gives a well rendered home screen.

leofreitas commented 1 year ago

I was unable to reproduce this bug. @taha-mahmoud-ly, can you test again and send a screenshot please?

taha-mahmoud-ly commented 1 year ago

Here it's.

with the Home screen widget enabled in Messenger settings. Post a new wall message and go to Home. the bug shows both in Arabic and English versions of the site. my environment: Alpine-based PHP-Nginx Docker container behind a traefik loadbalancer.

Home with widget disabled (Note the message notification ) Screenshot from 2023-06-07 19-18-10


Home with widget enabled (Sidebar fails to render) Screenshot from 2023-06-07 19-15-54

Home with widget enabled and no wall Messages (notice the off message notification) Screenshot from 2023-06-07 19-29-41

leofreitas commented 1 year ago

What version of php?

taha-mahmoud-ly commented 1 year ago

What version of php?

PHP Version 8.1.18

SKuipers commented 1 year ago

Thanks @taha-mahmoud-ly I'm just circling back to some of the open issues and I think this issue has since been fixed here: https://github.com/GibbonEdu/core/commit/7ca4d27dbe15c2f6b07d54aaf9cbf81f504825e6. Please do let us know if the error persists, thanks.