Format: new functions for readable date-time conversion

GibbonEdu / core

Gibbon is a flexible, open source school management platform designed to make life better for teachers, students, parents and leaders.

https://gibbonedu.org

GNU General Public License v3.0

460 stars 299 forks source link

Format: new functions for readable date-time conversion #1758

Closed yookoala closed 3 months ago

yookoala commented 9 months ago

Description

dateIntlReadable to replace dateReadable
dateTimeIntlReadable to replace dateTimeReadable
Add test coverage to Format::dateTimeReadable, Format::dateIntlReadable and Format::dateTimeIntlReadable.

Motivation and Context

Pave way to refactor away the remaining usages of strftime (see #1643).

How Has This Been Tested?

Locally.
CI environment.

yookoala commented 3 months ago

@SKuipers: Thanks. Take care.

yookoala commented 3 months ago

@SKuipers: Sorry, but I haven't implemented the fallback yet.

The last I checked, the amount of code needed would be huge, and I don't yet have the time to do it. I'd suggest to simply use https://github.com/symfony/polyfill-intl-icu in our case. The polyfill will only be loaded when IntlDateFormatter does not exists in the environment. The package size of Gibbon would be a bit bigger, unfortunately, but this will elegantly solve the backward compatibility issue with minimal work.