search

GibbonEdu / core

Gibbon is a flexible, open source school management platform designed to make life better for teachers, students, parents and leaders.
https://gibbonedu.org
GNU General Public License v3.0
460 stars 299 forks source link

Refactoring $gibbon->session variable to $session #1776

Closed felixOlesen closed 7 months ago

felixOlesen commented 7 months ago

Description Replaced session call through $gibbon->session to $session. $gibbon->session is now deprecated. Changes were made taking php functions and classes into account such that $gibbon->$session should no longer exist in the core code base.

How Has This Been Tested? Tested locally.

SKuipers commented 7 months ago

Thanks Felix, looks like the CI robots have caught some issues when testing, see if you can trace them back to the files in question: https://github.com/GibbonEdu/core/actions/runs/7471398671/job/20331619554?pr=1776

yookoala commented 7 months ago

@felixOlesen: Some advice in debugging.

At the summary page of each job, you may find artifacts produced in run time:

圖片

Within the zip file (folder: tests/_output), there are files generated for the failed tests. If you have a local development server running Gibbon at http://127.0.0.1:8888, you may even see the proper render output when opening the HTML files.

The files are the page(s) when CI test failed to get the expected result. There are usually some error message(s) there useful for debugging.

圖片

If not, you may check the render output to find something missing (or found an unexpected page rendered).

yookoala commented 7 months ago

Looks good to me :-)