GibbonEdu / core

Gibbon is a flexible, open source school management platform designed to make life better for teachers, students, parents and leaders.
https://gibbonedu.org
GNU General Public License v3.0
460 stars 299 forks source link

GitHub Actions: CI to check PHP Notice #1787

Closed yookoala closed 6 months ago

yookoala commented 6 months ago

Description

Motivation and Context Sometimes changes in code would generate notice that are expose incorrect assumption and hence potential problem, for example:

圖片

(from: https://github.com/GibbonEdu/core/actions/runs/7955085821)

Extracting and showing verbose log about it can provide vital hints for code improvements.

How Has This Been Tested?

Tested the base script locally against the log with notice: 圖片

yookoala commented 6 months ago

@SKuipers: The GitHub Action for CI Test will now show a new "Check PHP notice in server_log" section that will have the log message extracted. But currently the step will be skipped if the test failed. Need one more update to have it visible.

See #1790.