search

GibbonEdu / core

Gibbon is a flexible, open source school management platform designed to make life better for teachers, students, parents and leaders.
https://gibbonedu.org
GNU General Public License v3.0
467 stars 303 forks source link

Refactoring: adding staff name to notifications #1797

Closed ali-ichk closed 6 months ago

ali-ichk commented 7 months ago

Description System: Add changes so that notifications show the name of the staff in the notification message/text and also the name of the student involved.

SKuipers commented 6 months ago

I've tested this out and everything looks great, thanks. In hindsight, since we've already changed the string in POEditor for the login failed message, and we can't easily change it back, we'll have to create a new string, so I took the opportunity to add the IP address to the notification message: https://github.com/GibbonEdu/core/commit/c524fae69333cba05c63efaff34a67b566e73fbf