Add symfony/polyfill-intl-icu as dependency

GibbonEdu / core

Gibbon is a flexible, open source school management platform designed to make life better for teachers, students, parents and leaders.

https://gibbonedu.org

GNU General Public License v3.0

467 stars 303 forks source link

Add symfony/polyfill-intl-icu as dependency #1834

Closed yookoala closed 4 months ago

yookoala commented 4 months ago

Description Provide fallback to older installations. Supports system without php's ext-intl installed.

Motivation and Context Helps with moving forward the #1758 changes without the huge workload to write fallback pattern calls.

How Has This Been Tested?

Not tested. But trusted the Symfony project get this right.

SKuipers commented 4 months ago

Hi @yookoala thank you again for moving us forward with the date formats. I've come up with another solution in #1836 that I think will give us the best of forward and backwards compatibility without needing to introduce a new dependency to the project. By decoupling the implementation from the date formatting, using a set of constants that align with how IntlDateFormatter works, I think the solution will hopefully prove to be readable and maintainable.