search

Gibe / Umbraco.Community.AzureSSO

Azure AD SSO module for Umbraco
MIT License
10 stars 8 forks source link

Changed namespace of `AddMicrosoftAccountAuthentication()` extension method #4

Closed leekelleher closed 1 year ago

leekelleher commented 1 year ago

Following my comment, https://github.com/Gibe/Our.Umbraco.AzureSSO/commit/07b181d12d77e524b74556a5b47561b17c734f6a#r98069150, I've changed namespace of AddMicrosoftAccountAuthentication() extension method to match IUmbracoBuilder, with a view to make it more developer friendly, e.g. in terms of (intellisense) discovery and reducing the using references at the top.

I appreciate this may feel quite opinionated and counter-intuitive at first. Hopefully it'll make sense.

Alternatively, the "Umbraco.Extensions" namespace could also be used, as that it included with Umbraco's global usings (referenced in their NuGet package).

stevetemple commented 1 year ago

Implemented directly on develop