Example 1 suggestions - Githubissues

GidonFrischkorn / Tutorial-MixtureModel-VWM

This repository contains R scripts & raw data to illustrate how to estimate measurement models for visual working memory tasks.

GNU General Public License v3.0

3 stars 1 forks source link

Closed venpopov closed 1 year ago

venpopov commented 1 year ago

For example 1, here are some clean-up suggestions:

in Model setup use the actual formula, not just the intercept, as we no longer discuss this super basic model in the tutorial and might be confusing

venpopov commented 1 year ago

Also, use the bmm::wrap function on line 44 instead of

RespErr = dplyr::case_when(RespErr < -pi ~ RespErr + 2*pi, RespErr > pi ~ RespErr - 2*pi, TRUE ~ RespErr)

write RespErr = bmm::wrap(RespErr)

GidonFrischkorn commented 1 year ago

Agreed. I have implemented these changes and will upload the changed files shortly.