GidonFrischkorn / Tutorial-MixtureModel-VWM

This repository contains R scripts & raw data to illustrate how to estimate measurement models for visual working memory tasks.
GNU General Public License v3.0
3 stars 1 forks source link

some IMM examples fit the wrong model #12

Closed venpopov closed 1 year ago

venpopov commented 1 year ago

bmm_examples/Example5_Oberauer2017_IMMabc.R - it fits the '3p' model, not the abc bmm_examples/Example5_Oberauer2017_IMMbsc.R - it fits the '3p' model, not the bsc bmm_examples/Example5_Oberauer2017_IMMfull.R - it fits the '3p' model, not the full

brms_examples/Example5_Oberauer2017_IMMabc.R - it uses bmm code, not brms, and also fits the '3p' model

venpopov commented 1 year ago

Actually, I see that you did it in separate sections, and all files first fit the 3p model. But there are also errors in the filenames for the output files.

bmm_examples/Example5_Oberauer2017_IMMabc.R

line 1 - the description only mentions the Bays model line 72 - filename is for the abc model, but the fit code is for the 3p model

bmm_examples/Example5_Oberauer2017_IMMbsc.R

line 232 - it checks if (!file.exists(here("output","fit_E5_OL2017_IMMabc.RData"))), but the fit, the saved output and the loaded output is the bsc model

bmm_examples/Example5_Oberauer2017_IMMfull.R

line 234-263 - three different model files are specified for the check if exists, for the output, or for the load.

My suggestions:

After that, everything is ready I think.

GidonFrischkorn commented 1 year ago

I have updated the Scripts as you proposed and set up a new script for fitting the 3-parameter Mixture Model for Example 5.