search

GidonFrischkorn / Tutorial-MixtureModel-VWM

This repository contains R scripts & raw data to illustrate how to estimate measurement models for visual working memory tasks.
GNU General Public License v3.0
3 stars 1 forks source link

13 update bmm examples #17

Closed GidonFrischkorn closed 4 months ago

GidonFrischkorn commented 5 months ago

This pull request contains the updated examples using the current bmm version. Prior to merging this into the master branch, we should consider creating a tag to allow users to access the scripts associated with the initial bmm release. In the long run this will likely be less relevant, but during the review process, I think it could be nice to be able to quickly switch back and forth between the different iterations of the Tutorial scripts.

In this pull request:

venpopov commented 5 months ago

Cool, thanks, I'll take a look now :)

GidonFrischkorn commented 5 months ago

I have now committed an updated version of the files addressing most of your comments. We should definately look into the issue with loading the files that I saved. On my machine I get no error messages and all the loaded objects have the class bmmfit. Maybe we need to have a look if the file option interacts with some other environment info that breaks portability between different setups.

venpopov commented 5 months ago

I have now committed an updated version of the files addressing most of your comments. We should definately look into the issue with loading the files that I saved. On my machine I get no error messages and all the loaded objects have the class bmmfit. Maybe we need to have a look if the file option interacts with some other environment info that breaks portability between different setups.

there shouldn't be a problem with the file option - both you and I when we run the models fresh we save the correct object. I suspect you might have uploaded some old fits to osf. Can you reupload your current fit objects after you confirm they are all bmmfits?

GidonFrischkorn commented 5 months ago

Just as a short update. I will run the examples over the weekend with v0.5.3 and then upload the new results files to OSF. I will sent you a notification once thats done, so that you can then check if all the files load correctly for you too.

GidonFrischkorn commented 5 months ago

I now updated the .rds files on OSF and ran all models with the newest bmm version. Now, with downloading the new saved bmmfits the error when loading them should no longer appear. I also addressed your other comments.

venpopov commented 4 months ago

Looks good and I can confirm all the bmm files now work for me as well. Is this ready to merge or have you done any changes in the last few weeks you might want to incorporate?