Gidsss / UwUIDE

A compiler made to be cute uwu >~<
6 stars 0 forks source link

Output Errors when Formatting isn't Possible #240

Closed HolyShaq closed 4 months ago

am-cid commented 4 months ago

The question is why. Why are we squiggly lining? Cant we just show the lexer/parser errors like usual?

cc: @chaaals @Gidsss

am-cid commented 4 months ago

The reason for the question is the inconsistency. Is formatting the only place the squiggly lines will be implemented or will it be for all errors?

HolyShaq commented 4 months ago

The question is why. Why are we squiggly lining? Cant we just show the lexer/parser errors like usual?

Thinking about it now, I think this might be better actually. Those errors have more useful context anyways. It slipped my mind hahahaha

The reason for the question is the inconsistency. Is formatting the only place the squiggly lines will be implemented or will it be for all errors?

It will only appear when the format button is clicked supposedly, so the former. I think ur right that it is inconsistent.

chaaals commented 4 months ago

@HolyShaq @am-cid I suggested yung squiggly lines because I thought ang context lang niya is nasa code editor/text widget and no need to provide more information sa user since we're code formatting, sorry! Late night brain fart

Pero sige mas madali i-implement if diretso compiler error table and consistent w/ the design.

HolyShaq commented 4 months ago

Oki, I will change the issue to that then. Push ako PR by tonight, thanks!

am-cid commented 4 months ago

merged #238, closing this