search

Gielert / NoodleJS

A NodeJS Mumble client
36 stars 14 forks source link

Change Volume #12

Closed Caindrac closed 5 years ago

Caindrac commented 6 years ago

Is it possible to change the volume on the fly? I have figured out how to add a audiofilter before the stream starts but would like to be able to change it after the audio is already playing.

Gielert commented 6 years ago

There is no way to change the volume on the fly yet. This feature was implemented in the pre 1.0 version. (https://github.com/Gielert/NoodleJS/blob/v0.0.9/lib/AudioStream.js#L33). This will then be used in the processAudioBuffer function (https://github.com/Gielert/NoodleJS/blob/v0.0.9/lib/AudioStream.js#L58)

It was the idea to implement this feature once again, but it got kind of on hold since I didn't have much time to maintain it again. I will check later if I have time, but in the meantime, feel free to make any adjustment necessary that meet your needs.

Gielert commented 5 years ago

Fixed in https://github.com/Gielert/NoodleJS/pull/13