Gielert / NoodleJS

A NodeJS Mumble client
36 stars 14 forks source link

Bump reported client version to 1.3 to fix server not reporting all channels #47

Closed TJ09 closed 2 years ago

TJ09 commented 2 years ago

I haven't dug into the mumble source to figure out exactly why, but it looks like the server alters its behavior based on the client version. In the case of #10, it wasn't sending ChannelState messages for all channels. This causes an exception while processing the ChannelState messages that are received in the event that one such missing channel is the parent of another channel.

Changing the reported client version from 1.0.0 to 1.3.0 solves this issue and seems reasonably recent enough to be a good target. On the other hand, I don't know where else the server may be varying its behavior according to client version, so this may also change behavior beyond just fixing #10.