GiellaLT-Archive / clean_lang_history

Clean histories in giellalt/lang-???
0 stars 1 forks source link

Critical bugs #1

Closed TinoDidriksen closed 1 year ago

TinoDidriksen commented 2 years ago

If this is what created e.g. https://github.com/giellalt/lang-kal/commits/main_with_history_fixed then there are critical bugs:

albbas commented 2 years ago

If this is what created e.g. https://github.com/giellalt/lang-kal/commits/main_with_history_fixed then there are critical bugs:

Thanks for the feedback!

I used gitk to get an overview of the git log and such. The main history view shows the correct commit dates, so I thought everything was fine and dandy.

first-lang-kal

* Commit dates are lost. Looks like all commits are from when the script was run.

* Commits have the runner as committer (with original committer as author).

Now that you mention it, I see that the committer and author info are different. author-committer-lang-kal

git filter-branch can be used to set committer name and date equal to the author ditto.

* Authors list is wrong. At least my name is, so probably others are.

I/We can fix the author info in svn2git-authors.txt, turn it into a git mailmap, and use git filter-repo --mailmap my-mailmap to correct the info in the repo.

I'm on vacation now, but can have a look at this when I'm back.

snomos commented 2 years ago

Commands to clean up history can be found here: https://github.com/giellalt/giella-core/issues/20#issuecomment-1135506061

albbas commented 1 year ago

All the above issues have been solved with the commits pushed today