Reoccurring gigs somehow have end date in the past; are archived

[Oscillope]

For one of my bands, all of our future rehearsals got archived - it looks like the "end date" of the gig is when the series of gigs was created (I'm not entirely sure since I didn't create the gigs, but it seems likely), which is now in the past. The "start date" is correct.

I don't know if this is a one-time fluke or not but I wanted to flag it here. The end times also got messed up, some of them seem to have been set to random times in the early morning (they should all be 8:30pm).

[aaronoppenheimer]

Hi - thanks for the report. You are right! Only the "call date" gets changed, the "end date" does not, which is a problem! I will fix, and then we can address how to handle the gigs that are broken. Shouldn't be too difficult, I just need to take a look and see the best way. I'm sorry this happened!

On Fri, Apr 12, 2024, at 3:40 PM, Oscillope wrote:

I'm not entirely sure how this happened, but for one of my bands, all of our future rehearsals got archived - it looks like the "end date" of the gig is when the series of gigs was created (I'm not entirely sure since I didn't create the gigs, but it seems likely), which is now in the past. The "start date" is correct.

I don't know if this is a one-time fluke or not but I wanted to flag it here. The end times also got messed up, some of them seem to have been set to random times in the early morning (they should all be 8:30pm).

sshot_2024-04-12_15.38.05.png (view on web) https://github.com/Gig-o-Matic/GO3/assets/2652071/c2363085-67c2-48e4-9afd-024325d1dd41

— Reply to this email directly, view it on GitHub https://github.com/Gig-o-Matic/GO3/issues/423, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWDDNX73SMOJ6MN32PWYMDY5A2BNAVCNFSM6AAAAABGEV4UVGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2DANZYG4ZTKMY. You are receiving this because you are subscribed to this thread.Message ID: @.***>

[aaronoppenheimer]

technical note

once #405 is merged, the problem is in this code:

if set_delta is not None:
  the_gig.setdate += set_delta

if end_delta is not None:
  the_gig.enddate += end_delta

Should be

the_gig.setdate = the_gig.date + set_delta

and same for enddate!

[Oscillope]

Thanks so much for looking into this! Let me know if there's anything we can do to get the gigs un-archived (or if it's better if we just recreate them that also wouldn't be the end of the world).

[aaronoppenheimer]

@bklang I'm just going to add the fix to #405

[Oscillope]

@aaronoppenheimer thanks again for the fix! Just wondering if you think you'll be able to un-archive the gigs or if we just recreate them?

[aaronoppenheimer]

If you send me a list I can help

On Thu, Apr 18, 2024, at 10:19 AM, Oscillope wrote:

@aaronoppenheimer https://github.com/aaronoppenheimer thanks again for the fix! Just wondering if you think you'll be able to un-archive the gigs or if we just recreate them?

— Reply to this email directly, view it on GitHub https://github.com/Gig-o-Matic/GO3/issues/423#issuecomment-2063989267, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWDDNWB45H7ICSOMLPRYULY57I5ZAVCNFSM6AAAAABGEV4UVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRTHE4DSMRWG4. You are receiving this because you were mentioned.Message ID: @.***>

[Oscillope]

Thanks!! Here you go: https://new.gig-o-matic.com/gig/716/ https://new.gig-o-matic.com/gig/717/ https://new.gig-o-matic.com/gig/718/ https://new.gig-o-matic.com/gig/719/ https://new.gig-o-matic.com/gig/720/ https://new.gig-o-matic.com/gig/721/ https://new.gig-o-matic.com/gig/722/

[aaronoppenheimer]

I have rescued (I think) the 4/22 gig - can you verify that it looks ok? If so, I can do the rest of them.

On Thu, Apr 18, 2024, at 10:25 AM, Oscillope wrote:

Thanks!! Here you go: https://new.gig-o-matic.com/gig/716/ https://new.gig-o-matic.com/gig/717/ https://new.gig-o-matic.com/gig/718/ https://new.gig-o-matic.com/gig/719/ https://new.gig-o-matic.com/gig/720/ https://new.gig-o-matic.com/gig/721/ https://new.gig-o-matic.com/gig/722/

— Reply to this email directly, view it on GitHub https://github.com/Gig-o-Matic/GO3/issues/423#issuecomment-2064003553, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWDDNVQYEBXL4CH6TPCWODY57JVPAVCNFSM6AAAAABGEV4UVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRUGAYDGNJVGM. You are receiving this because you were mentioned.Message ID: @.***>

[Oscillope]

Thanks!! The gig is there! The times are wrong though (should be 6:30 call/set, 8:30 end).On Apr 19, 2024, at 6:35 PM, aaronoppenheimer @.***> wrote:

I have rescued (I think) the 4/22 gig - can you verify that it looks ok? If so, I can do the rest of them.

On Thu, Apr 18, 2024, at 10:25 AM, Oscillope wrote:

Thanks!! Here you go:

https://new.gig-o-matic.com/gig/716/

https://new.gig-o-matic.com/gig/717/

https://new.gig-o-matic.com/gig/718/

https://new.gig-o-matic.com/gig/719/

https://new.gig-o-matic.com/gig/720/

https://new.gig-o-matic.com/gig/721/

https://new.gig-o-matic.com/gig/722/

—

Reply to this email directly, view it on GitHub https://github.com/Gig-o-Matic/GO3/issues/423#issuecomment-2064003553, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWDDNVQYEBXL4CH6TPCWODY57JVPAVCNFSM6AAAAABGEV4UVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRUGAYDGNJVGM.

You are receiving this because you were mentioned.Message ID: @.***>

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

[aaronoppenheimer]

OK! I've fixed them all - please verify that I set the end times correctly. Thanks for your patience!

A

On Fri, Apr 19, 2024, at 11:27 PM, Oscillope wrote:

Thanks!! The gig is there! The times are wrong though (should be 6:30 call/set, 8:30 end).On Apr 19, 2024, at 6:35 PM, aaronoppenheimer @.***> wrote:

I have rescued (I think) the 4/22 gig - can you verify that it looks ok? If so, I can do the rest of them.

On Thu, Apr 18, 2024, at 10:25 AM, Oscillope wrote:

Thanks!! Here you go:

https://new.gig-o-matic.com/gig/716/

https://new.gig-o-matic.com/gig/717/

https://new.gig-o-matic.com/gig/718/

https://new.gig-o-matic.com/gig/719/

https://new.gig-o-matic.com/gig/720/

https://new.gig-o-matic.com/gig/721/

https://new.gig-o-matic.com/gig/722/

—

Reply to this email directly, view it on GitHub https://github.com/Gig-o-Matic/GO3/issues/423#issuecomment-2064003553, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWDDNVQYEBXL4CH6TPCWODY57JVPAVCNFSM6AAAAABGEV4UVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRUGAYDGNJVGM.

You are receiving this because you were mentioned.Message ID: @.***>

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/Gig-o-Matic/GO3/issues/423#issuecomment-2067532410, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWDDNVWRCOTMAJ3VYNRQR3Y6HOB7AVCNFSM6AAAAABGEV4UVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRXGUZTENBRGA. You are receiving this because you were mentioned.Message ID: @.***>

[Oscillope]

Great, they all look good now! Thanks again!