Gig-o-Matic / GO3

GNU General Public License v3.0
10 stars 8 forks source link

"Hide Canceled Gigs" changes time for other gigs in Schedule view #427

Closed SethPate closed 7 months ago

SethPate commented 7 months ago

Recently turned on the (very helpful) feature to hide cancelled gigs, but every other gig is set three hours behind. Maybe a time zone thing? All-day gigs have a date that is off by one day (early).

An example gig; the time here is correct:

image

Displays as:

image
kalebabebe commented 7 months ago

Also noticed this but the issue doesn't appear related to "hide cancelled gig" setting, revering the setting still shows incorrect time

I think this might be the troublesome pr- https://github.com/Gig-o-Matic/GO3/commit/5a64c902ede6b79c43105e12368de1bce3fb5b8d

aaronoppenheimer commented 7 months ago

Hi all - that PR is the problem because it's the first time we've put the time on the schedule page, revealing the issue. The trouble seems to be that the "schedule" page doesn't activate the user's timezone before displaying those times. I have been able to replicate the behavior.

Try this: if the time looks bad on the schedule page, click on a gig, verify its time is right, and then click on the "gig-o-matic" logo to go back to the schedule page (don't just hit 'back'). Are the times correct now? That's how it's working for me in the development environment.

I am pushing through a fix that should help on the schedule page - though I also note that the times aren't always correct on the "calendar" page, probably for a similar reason. Will take a look today!

SethPate commented 7 months ago

Clicking the gig-o-log-o does correct the times for me.

On Apr 15, 2024, at 8:53 AM, aaronoppenheimer @.***> wrote:

Hi all - that PR is the problem because it's the first time we've put the time on the schedule page, revealing the issue. The trouble seems to be that the "schedule" page doesn't activate the user's timezone before displaying those times. I have been able to replicate the behavior.

Try this: if the time looks bad on the schedule page, click on a gig, verify its time is right, and then click on the "gig-o-matic" logo to go back to the schedule page (don't just hit 'back'). Are the times correct now? That's how it's working for me in the development environment.

I am pushing through a fix that should help on the schedule page - though I also note that the times aren't always correct on the "calendar" page, probably for a similar reason. Will take a look today!

— Reply to this email directly, view it on GitHub https://github.com/Gig-o-Matic/GO3/issues/427#issuecomment-2056785088, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEEGJJIRWDHW5ZUFDBBPABTY5PEWBAVCNFSM6AAAAABGGRB6PCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJWG44DKMBYHA. You are receiving this because you authored the thread.

aaronoppenheimer commented 7 months ago

Great. I just pushed through a change that should fix it. To make sure, you could log all the way out of the gig-o and back in - when you first see the schedule page it should show the times correctly.

thanks for your help!

A

On Mon, Apr 15, 2024, at 11:27 AM, Seth Pate wrote:

Clicking the gig-o-log-o does correct the times for me.

On Apr 15, 2024, at 8:53 AM, aaronoppenheimer @.***> wrote:

Hi all - that PR is the problem because it's the first time we've put the time on the schedule page, revealing the issue. The trouble seems to be that the "schedule" page doesn't activate the user's timezone before displaying those times. I have been able to replicate the behavior.

Try this: if the time looks bad on the schedule page, click on a gig, verify its time is right, and then click on the "gig-o-matic" logo to go back to the schedule page (don't just hit 'back'). Are the times correct now? That's how it's working for me in the development environment.

I am pushing through a fix that should help on the schedule page - though I also note that the times aren't always correct on the "calendar" page, probably for a similar reason. Will take a look today!

— Reply to this email directly, view it on GitHub https://github.com/Gig-o-Matic/GO3/issues/427#issuecomment-2056785088, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEEGJJIRWDHW5ZUFDBBPABTY5PEWBAVCNFSM6AAAAABGGRB6PCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJWG44DKMBYHA. You are receiving this because you authored the thread.

— Reply to this email directly, view it on GitHub https://github.com/Gig-o-Matic/GO3/issues/427#issuecomment-2057135254, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWDDNT57AUF5ZEPDDXEBXLY5PWX7AVCNFSM6AAAAABGGRB6PCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJXGEZTKMRVGQ. You are receiving this because you commented.Message ID: @.***>