search

Gig-o-Matic / GO3

GNU General Public License v3.0
10 stars 8 forks source link

fully qualified band "Website" URL looks like it should work but does not #445

Closed nocturne-mit closed 7 months ago

nocturne-mit commented 7 months ago

When setting up my newest band, I put a fully qualified URL (e.g. "https://foo.org/") in the band's "website" field. This HTTPS URL is displayed verbatim as text when you view the band-info page, but if you click on the link, it's actually a hyperlink to "http://https//foo.org/".

Feel free to solve this however seems best, but in case suggestions are helpful, you could take one of these approaches:

  1. Forbid entry of a URL that specifies the URL scheme (i.e. "https:"), but this means people can't specify https:// URLs for sites that don't have working HTTP-to-HTTPS redirection
  2. On the band-info display page, only prepend "http:" when the URL doesn't already start with a URL scheme (flexible for bands, but maybe harder to code)
aaronoppenheimer commented 7 months ago

should be addressed in #446