Gcal feed includes cancelled and archived gigs

[nocturne-mit]

The google-calendar feed for my bands includes cancelled and archived gigs, for example: https://www.gig-o-matic.com/gig/3340/ (cancelled) https://www.gig-o-matic.com/gig/280/ (cancelled and archived) https://www.gig-o-matic.com/gig/279/ (archived but not cancelled - we replaced this multi-day placeholder with a bunch of per-day events)

The gcal feed would be more usable if it did not include cancelled or archived gigs, or if it did not default to including them.

[aaronoppenheimer]

Hm - it's true that the band calfeed was serving trashed gigs (fixed in #547) but should not be serving canceled gigs - I can't replicate it.

Archived gigs should be served since they're usually gigs that actually happened and the calfeed is retroactive for a year. If you want to actually delete a gig, it should go in the trash.

[nocturne-mit]

That’s good to know about the intended function of archived gigs!

It would be great if we can someday figure out why cancelled gigs are showing up, though. My bandmate reported that to me last week and I was immediately able to verify with https://www.gig-o-matic.com/gig/3340/ which is a recently-created 1-day gig that was subsequently cancelled.

[aaronoppenheimer]

Hm. If I look at the calendar feed for the band, that gig is not listed. Where are you seeing it?

On Sun, Sep 22, 2024, at 10:29 PM, Eric Mumpower wrote:

That’s good to know about the intended function of archived gigs!

It would be great if we can someday figure out why cancelled gigs are showing up, though. My bandmate reported that to me last week and I was immediately able to verify with https://www.gig-o-matic.com/gig/3340/ which is a recently-created 1-day gig that was subsequently cancelled.

— Reply to this email directly, view it on GitHub https://github.com/Gig-o-Matic/GO3/issues/546#issuecomment-2367131069, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWDDNVOTFSZNMJO7KFCD5TZX54KNAVCNFSM6AAAAABOQ4HLY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRXGEZTCMBWHE. You are receiving this because you commented.Message ID: @.***>

[nocturne-mit]

I’m seeing it in my personal gigo calendar feed that includes all my bands. When I originally reported this bug, I was seeing this issue when I subscribed to that personal gigo calendar URL from my personal google calendar account. I added that personal feed URL for the first time to my iOS calendar last night shortly before replying, and did indeed see that gig, as well as the other cancelled-and-archived gig I mentioned, in my iphone’s view of that calendar.

[aaronoppenheimer]

Aha, I see. It's the personal calfeed, not the "band calfeed" which is public gigs for a single band.

In this case, you're right, it's returning canceled gigs. There is an option to only show gigs with a status of "confirmed" which does filter out canceled gigs, but it also filters out not-canceled but not-yet-confirmed gigs. I'll think about whether it's better to change that to "hide canceled gigs" in which case it'll show confirmed AND non-confirmed gigs, or if there should be another option which hides canceled gigs but leaves the option to show non-confirmed gigs or not. There are probably two different use cases - one for more admin types who want to see everything possibly coming up, and one for rank-and-file members who just want to know what's confirmed. Or maybe not - maybe better to show everything to everyone except cancelled gigs. What do you think?

A

On Mon, Sep 23, 2024, at 7:44 AM, Eric Mumpower wrote:

I’m seeing it in my personal gigo calendar feed that includes all my bands. When I originally reported this bug, I was seeing this issue when I subscribed to that personal gigo calendar URL from my personal google calendar account. I added that personal feed URL for the first time to my iOS calendar last night shortly before replying, and did indeed see that gig, as well as the other cancelled-and-archived gig I mentioned, in my iphone’s view of that calendar.

On Sep 22, 2024, at 10:35 PM, aaronoppenheimer @.***> wrote:



Hm. If I look at the calendar feed for the band, that gig is not listed. Where are you seeing it?

On Sun, Sep 22, 2024, at 10:29 PM, Eric Mumpower wrote:

That’s good to know about the intended function of archived gigs!

It would be great if we can someday figure out why cancelled gigs are showing up, though. My bandmate reported that to me last week and I was immediately able to verify with https://www.gig-o-matic.com/gig/3340/ which is a recently-created 1-day gig that was subsequently cancelled.

— Reply to this email directly, view it on GitHub https://github.com/Gig-o-Matic/GO3/issues/546#issuecomment-2367131069, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWDDNVOTFSZNMJO7KFCD5TZX54KNAVCNFSM6AAAAABOQ4HLY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRXGEZTCMBWHE. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHubhttps://github.com/Gig-o-Matic/GO3/issues/546#issuecomment-2367134876, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABIH4D5LPVO5VZK7YRIDNT3ZX546VAVCNFSM6AAAAABOQ4HLY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRXGEZTIOBXGY. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/Gig-o-Matic/GO3/issues/546#issuecomment-2367970501, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWDDNSFKZSYWWRFGYT2HGLZX75KRAVCNFSM6AAAAABOQ4HLY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRXHE3TANJQGE. You are receiving this because you commented.Message ID: @.***>

[aaronoppenheimer]

OK, with some more research, there's already a solution. In your preferences is a checkbox for "hide canceled gigs" - but it's at the very top and easily missed, I think. It's definitely not set in your preferences. If you tick that, the canceled gigs should go away.

I moved it in #548 for better visibility. Maybe it should be checked by default.