Closed wluo closed 10 years ago
misterbisson
commented
10 years ago Looks good. My question in https://github.com/GigaOM/go-sphinx/pull/31#discussion_r12894036 is about what happens when we don't set an orderby value on non-keyword queries. Those need to be ordered by date.
gigabot
commented
10 years ago | Status | Message | Line |
|---|---|---|
| :warning: | Comment refers to a TODO task "add all filters here if we're going to remove them all" | class-go-sphinx.php:239 |
| :x: | Don't leave error_log lying around | class-go-sphinx.php:370 |
| :x: | Don't leave error_log lying around | class-go-sphinx.php:395 |
| :x: | Don't leave error_log lying around | class-go-sphinx.php:570 |
| :warning: | Comment refers to a TODO task "report back that one or more requested terms" | class-go-sphinx.php:783 |
via jenkins/codesniffer
misterbisson
commented
10 years ago :pickles:
this pull request also needs https://github.com/GigaOM/gigaom/pull/4432 for the go-sphinx config file update.
see https://github.com/GigaOM/legacy-pro/issues/3248