GigaSpaces-ProfessionalServices / AdminApiMonitor

Admin API logging implementation
0 stars 0 forks source link

Change cpu_usage to use OperatingSystemsStatistics #28

Closed jasonnerothin closed 10 years ago

jasonnerothin commented 10 years ago

https://github.com/OpenSpaces/OpenSpaces/blob/master/src/main/java/org/openspaces/admin/os/OperatingSystemsStatistics.java

jasonnerothin commented 10 years ago

Once the feature is in, let's merge everything (except rfx) back to master.

promanenko commented 10 years ago

I reviewed WebUI implementation and realized OperatingSystemsStatistics is used to get overall CPU usage. (VirtualMachineStatistics#getCpuPerc()/cpuNumber)*100 is used for GSC CPU usage calculation.

I could implement using: (VirtualMachineStatistics#getCpuPerc()/cpuNumber)*100" but this would mean that it wouldn't be exactly accurate because we just divide overall usage by CPU cores.

promanenko commented 10 years ago

implemented as (VirtualMachineStatistics#getCpuPerc()/cpuNumber)*100