search

Giggitybyte / SleepWarp

Minecraft Fabric mod which speeds up time when sleeping instead of skipping directly to day.
Mozilla Public License 2.0
14 stars 6 forks source link

[v2.1.0 for MC 1.20] Ticked blocks duplicated 16 blocks below #25

Open DrPprLvr opened 1 year ago

DrPprLvr commented 1 year ago

I've noticed farmland and other ticked blocks like vines are duplicated 16 blocks below. Behavior observed on both server and single player instances in 1.20 with only fabric API and mod menu installed.

DrPprLvr commented 1 year ago

Video example

https://youtu.be/OuxCPBROCNQ

Giggitybyte commented 1 year ago

Oh geez, that's a crazy one. Thank you for catching this! I believe I know what the cause is but I won't be able to properly debug, test, and push an update until late next week.

Viotomix commented 1 year ago

Could you take down the 1.20 file from modrinth, or add a displaimer to the download until this is fixed? This issue fucked up a base on my server and irreperably destroyed important chests multiple times until I finally managed to track down what was causing it. Wouldn't want that happening to other people.

Unleashed75 commented 1 year ago

I gotta say that this is not a "bug" it is a Major Issue!! and I agree, this 1.20 version and the 1.20.1 version should be taken down asap so you don't wreck other peoples worlds and have them searching for hours trying to find that it is your mod and that you knew about it for weeks

Jh16 commented 1 year ago

I just discovered this issue on a server I'm a part of. Fortunately, before updating to 1.20.1 from 1.19.4 I made a full back-up and only about 5 or 6 hours worth of work was lost. Currently doing that restore from the backup. Would have been nice if it wasn't up on anywhere when I was going through the mod list updating them.

theinfamousmielie commented 1 year ago

Same. Posted here, as it seems related: https://github.com/Giggitybyte/SleepWarp/issues/28

MaxenceDC commented 1 year ago

Oh geez, that's a crazy one. Thank you for catching this! I believe I know what the cause is but I won't be able to properly debug, test, and push an update until late next week.

@Giggitybyte! Any news on the update? It's been much longer than "next week"!

For anyone looking for an alternative, there is this mod : https://modrinth.com/mod/realisticsleep which is available also for 1.20.1 Quilt&Fabric, without this bug and some similar features (seeds and trees don't grow faster but furnaces work)

InFTord commented 1 year ago

Oh geez, that's a crazy one. Thank you for catching this! I believe I know what the cause is but I won't be able to properly debug, test, and push an update until late next week.

@Giggitybyte! Any news on the update? It's been much longer than "next week"!

For anyone looking for an alternative, there is this mod : https://modrinth.com/mod/realisticsleep which is available also for 1.20.1 Quilt&Fabric, without this bug and some similar features (seeds and trees don't grow faster but furnaces work)

he got a new job currently, too busy to work on any MC stuff

Giggitybyte commented 1 year ago

@Giggitybyte! Any news on the update? It's been much longer than "next week"!

I've had a lot of stuff going on in my life (the most recent thing being a new job, as Inf mentioned) and I haven't had any time to even think about any of my hobby programming projects the past few months. I have removed v2.1.0 on GitHub and Curseforge, and the Modrinth moderation team has removed that version on their site a few weeks ago at the request of users who were experiencing this bug. I currently have no idea how to fix this issue; most of the logic for speeding up random ticks is pulled from vanilla code and this issue does not happen in vanilla, and what debugging I did do in June did not yield any clues on the actual issue and what needed to be fixed.

If you have this version and you've slept already with tick_random_block set to true; I apologize for the damage done to your world. I did not intend for it to happen and I did not expect to have my time become so limited. If you decide you still want to use SleepWarp v2.1.0 on new 1.20 worlds, be sure to set tick_random_block to false to avoid this issue.

Also, to be super clear: this issue only affects v2.1.0 (MC 1.20). Mojang changed the random tick code in 1.20 and I attempted to mimic that logic and managed to create this bug; v2.0.0 (MC 1.19.4) and below use different logic and do not have this issue.

I am trying to get back into modding again as time allows. Sometime in the near future I'll push out a fixed version for 1.20 then sometime shortly after that I plan to work on and release versions for Forge and Quilt.