Open GiggleLiu opened 4 years ago
Merging #35 into master will increase coverage by
0.25%
. The diff coverage is94.73%
.
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 81.72% 81.98% +0.25%
==========================================
Files 25 26 +1
Lines 1029 1049 +20
==========================================
+ Hits 841 860 +19
- Misses 188 189 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/stdlib/rng.jl | 94.73% <94.73%> (ø) |
|
src/autodiff/checks.jl | 90.66% <0.00%> (-0.13%) |
:arrow_down: |
src/stdlib/mapreduce.jl | 100.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9ce20ec...980462c. Read the comment docs.
Getting PPL to work in this way could be challenging, but having a reversible RNG at all will make it now easy to try out some different ideas. We can look more closely at the quality of the RNG and see if we need an alternative if/when we get to that point. Thanks!
Getting PPL to work in this way could be challenging
Always ready to backup your new ideas, at least from the technical side.
We can look more closely at the quality of the RNG
This is why we need experts!
References:
fix #34
This is an implementing reversible linear congruential generator, does this fit your using case? @cscherrer