GijsGoudzwaard / Image-Optimizer

Simple lossless compression for Elementary OS
MIT License
81 stars 10 forks source link

Missleading icon #10

Closed RafaelCz closed 7 years ago

RafaelCz commented 7 years ago

The icon you are using in the drop area (arrow pointing to a cloud) may create the impression that this app is using an online service to compress the files. Since this isn't the case, I'd suggest you choose an appropriate icon.

Beside that this icon looks like it's straight out of an iPhone/Mac app, it doesn't really fit the HIG of elementary OS ;)

GijsGoudzwaard commented 7 years ago

You are right, the current icon does create the impression of uploading to a cloud.

yeboahnanaosei commented 7 years ago

Yeah bro. I will recommend you read the Human Interface Guidelines of elementary OS. that is if you have not already done that

micahilbery commented 7 years ago

I would love to help out if you'd have it. I have threw together a icon if it looks good to you I'll send a PR. upload-icon

UPDATED: upload_icon

micahilbery commented 7 years ago

Here's what it looks like in app. screenshot from 2017-09-30 21 58 25

yeboahnanaosei commented 7 years ago

Guy, can we get rid of the arrow. I feel it is the arrow that is causing the problem. The arrow makes it feel like you would upload the file. I imagine something like this would be cool:

op
micahilbery commented 7 years ago

The arrow shows you need action. You need to put a image into the app for it to do something. So in a sense you are uploading a file, just into the app and not the cloud. If you didn't have any words and all you saw was the image you should still be able to figure out what to do. I feel like without the arrow an image of a picture could mean anything (like the app is loading and this is a splash img, or that it will display pictures here, ect.)

yeboahnanaosei commented 7 years ago

I understand you perfectly. But in keeping with elementary's HIG, I thought it would help make the app feel more consistent and even more native if you just had an icon and few words instructing the user on what to do. And here is the case we do know what the app does before installing. Take a look at these apps by elementary

screenshot from 2017-10-01 04-09-49

screenshot from 2017-10-01 04-11-56

The final decision rests with the developer of course.

micahilbery commented 7 years ago

All the icons here have action parts though like pluses and arrows except the folder icons. Maybe instead of an arrow it would be better to use a "+" or something? Or maybe instead it should use the built-in "insert-image" icon?

Built-In icon insert-image

Example screenshot: screenshot from 2017-09-30 21 58 25

yeboahnanaosei commented 7 years ago

No problem. The only issue I personally have is with the arrow. That's all

micahilbery commented 7 years ago

The more I think on it the more I really think we should be using the built-in action icon for this. That is one less custom icon that has to be shipped. And not that this is meant to be used with other icon themes doing so would mean that the icon would adapt to a that theme change.

GijsGoudzwaard commented 7 years ago

While that would be a good alternative, I don't really think that that icons fits the theme of this app. An alternative to the current icon could be just a '+' in purple.

micahilbery commented 7 years ago

Hows this? upload_icon

screenshot from 2017-10-06 10 39 03

micahilbery commented 7 years ago

I also tried keeping the green plus and instead giving it the same picture as the app icon. screenshot from 2017-10-06 10 13 25

GijsGoudzwaard commented 7 years ago

I quite like the second icon (with the green +). Could you create a pull request that changes the upload icon?

micahilbery commented 7 years ago

Will do as soon as I get back to my computer.